Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SAGEMAKER_MODEL_SERVER_TIMEOUT_SECONDS variable #129

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

davidthomas426
Copy link
Contributor

@davidthomas426 davidthomas426 commented Jun 18, 2023

Issue #, if available:

Description of changes:
This provides a way for the customer to provide a timeout value specifically in seconds. This is needed due to a bug in multi-model-server that interpreted the existing timeout value in minutes even though it was documented to be in seconds.

We introduced a new variable rather than changing the meaning of the old variable out of concerns around backward-compatibility. We can revisit this later if needed.

Testing done:

Unit tests all passed.

Installed modified versions of MMS and this toolkit in a container and ran an end-to-end example to trigger the timeout to verify it works. It does :)

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have used the regional endpoint when creating S3 and/or STS clients (if appropriate)
  • I have updated any necessary documentation, including READMEs

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-inference-toolkit-pr
  • Commit ID: f955aa6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants