Add support for SAGEMAKER_MODEL_SERVER_TIMEOUT_SECONDS variable #129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This provides a way for the customer to provide a timeout value specifically in seconds. This is needed due to a bug in multi-model-server that interpreted the existing timeout value in minutes even though it was documented to be in seconds.
We introduced a new variable rather than changing the meaning of the old variable out of concerns around backward-compatibility. We can revisit this later if needed.
Testing done:
Unit tests all passed.
Installed modified versions of MMS and this toolkit in a container and ran an end-to-end example to trigger the timeout to verify it works. It does :)
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.