fix: Create custom tarfile extractall util to fix backward compatibility issue #4476

knikure · 2024-03-05T06:28:16Z

Issue #, if available:

Description of changes:
Add fixes for tarfile extractall functionality per PEP-721. As part of the fix, we rely on tarfile liraries data filter functionality to have a secure path forward to (works well with Python 3.12+) and additionally I have created a custom tarfile extractall util to fix backward compatibility issue with Python<3.12 versions.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

mufaddal-rohawala · 2024-03-05T06:52:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 049e655
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-03-05T07:20:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 049e655
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-03-05T07:20:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 049e655
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-03-05T07:23:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 049e655
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-03-05T07:29:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 049e655
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

knikure

/bot run unit-tests

mufaddal-rohawala · 2024-03-05T17:17:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 049e655
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov · 2024-03-05T17:18:21Z

Codecov Report

Attention: Patch coverage is 50.90909% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 87.21%. Comparing base (8b206ba) to head (9db0539).
Report is 63 commits behind head on master.

Files	Patch %	Lines
src/sagemaker/workflow/_repack_model.py	33.33%	16 Missing ⚠️
src/sagemaker/utils.py	54.16%	11 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4476      +/-   ##
==========================================
+ Coverage   86.94%   87.21%   +0.27%     
==========================================
  Files        1203      388     -815     
  Lines      107211    36332   -70879     
==========================================
- Hits        93211    31687   -61524     
+ Misses      14000     4645    -9355

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mufaddal-rohawala · 2024-03-05T17:53:44Z

src/sagemaker/utils.py

+            print(stderr, file_info.name, "is blocked (illegal path)")
+        elif file_info.issym() and _is_bad_link(file_info, base):
+            print(stderr, file_info.name, "is blocked: Symlink to", file_info.linkname)
+        elif file_info.islnk() and _is_bad_link(file_info, base):
+            print(stderr, file_info.name, "is blocked: Hard link to", file_info.linkname)
+        else:


Can you add coverage for these paths?

src/sagemaker/workflow/_repack_model.py

src/sagemaker/utils.py

src/sagemaker/workflow/_repack_model.py

src/sagemaker/utils.py

mufaddal-rohawala · 2024-03-05T23:43:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: f758927
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-03-05T23:44:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: f758927
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-03-05T23:53:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: f758927
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-03-06T00:26:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: f758927
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-03-06T00:46:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: f758927
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

qidewenwhen · 2024-03-06T02:30:01Z

src/sagemaker/utils.py

@@ -1553,20 +1553,23 @@ def safe_members(members):

    for file_info in members:
        if _is_bad_path(file_info.name, base):
-            print(stderr, file_info.name, "is blocked (illegal path)")
+            logger.error(stderr, file_info.name, "is blocked (illegal path)")


Have we checked the error log in console via unit test?
I have not seen this log format so hoping to confirm if it can print out the message as expected.
Usually we use format like :

logger.debug( "Selecting TrainingInput's input_mode (%s) for TrainingInputMode.", inputs.config["InputMode"], )

Ref:

sagemaker-python-sdk/src/sagemaker/estimator.py

Lines 2491 to 2494 in 3aa0a56

logger.debug(

"Selecting TrainingInput's input_mode (%s) for TrainingInputMode.",

inputs.config["InputMode"],

)

mufaddal-rohawala · 2024-03-06T03:10:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 7a8b6a1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-03-06T03:53:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 7a8b6a1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-03-06T03:59:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 7a8b6a1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-03-06T04:26:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 7a8b6a1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-03-06T04:38:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 7a8b6a1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…ity issue

mufaddal-rohawala · 2024-03-06T07:29:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 9db0539
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-03-06T07:30:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 9db0539
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-03-06T07:35:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 9db0539
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-03-06T08:49:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 9db0539
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-03-06T09:16:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 9db0539
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

knikure

/bot run notebook-tests

diggerdan · 2024-03-06T15:19:42Z

Hello, and thank you for working on this.

We are eagerly awaiting this fix, as our current Sagemaker Studio model deployment workflow is blocked because of this TarFile.extractall() issue.

mufaddal-rohawala · 2024-03-06T15:44:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 9db0539
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

johnrwoolley · 2024-03-07T14:19:53Z

Just wanted to thank you for this patch - I was tearing my hair out yesterday trying to work out how to get around this issue so I could run a sagemaker batch transform job. Could hardly believe a patch arrived just when I needed it 😄

…ity issue (aws#4476) * fix: Create custom tarfile extractall util to fix backward compatibility issue * Address review comments * fix logger.error statements

* prepare release v2.210.0 * update development version to v2.210.1.dev0 * feat: Add new Triton DLC URIs (#4432) * Add new Triton DLC URIs * Update according to black and pylint * feat: Support selective pipeline execution between function step and regular step (#4392) * feat: Add AutoMLV2 support (#4461) * Add AutoMLV2 support * Improvements of the integration tests --------- Co-authored-by: Anton Repushko <repuanto@amazon.com> * feature: Add TensorFlow 2.14 image configs (#4446) * fix: remove enable_network_isolation from the python doc (#4465) Co-authored-by: Rohan Gujarathi <gujrohan@amazon.com> * doc: Add doc for new feature processor APIs and classes (#4250) * fix: properly close sagemaker config file after loading config (#4457) Closes #4456 * feat: instance specific jumpstart host requirements (#4397) * feat: instance specific jumpstart host requirements * chore: add js support for copies resource requirement, enforce coupling with ResourceRequirements class * fix: typing * fix: pylint * change: Bump Apache Airflow version to 2.8.2 (#4470) * Update tox.ini * Update test_requirements.txt * fix: make sure gpus are found in local_gpu run (#4384) * fix: make sure gpus are found in local_gpu run * fix: black formatting * fix: adjust unit test * feat: pin dll version to support python3.11 to the sdk (#4472) Co-authored-by: Ashwin Krishna <ashwikri@amazon.com> * fix: Skip No Canvas regions for test_deploy_best_candidate (#4477) * prepare release v2.211.0 * update development version to v2.211.1.dev0 * change: Enhance model builder selection logic to include model size (#4429) * change: Enhance model builder selection logic to include model size * Fix conflicts * Address PR comments * fix formatting * fix formatting of test * Fix token in tasks.json * Increase coverage for tests * fix formatting * Fix requirements * Import code instead of importing accelerate * Fix formatting * Setup dependencies * change: Upgrade smp to version 2.2 (#4479) * upgrading smp to version 2.2 * fixing linting issue * fixing syntax error with multiline if statement * upgrading smp to version 2.2 * fixing linting issue * fixing syntax error with multiline if statement * fixing formatting --------- Co-authored-by: Andrew Tian <tinandr@amazon.com> * feat: Update SM Python SDK for PT 2.2.0 SM DLC (#4481) * update pt2.2 sm training dlc pysdk * update pt2.2 sm inference dlc pysdk and region list * fix: Create custom tarfile extractall util to fix backward compatibility issue (#4476) * fix: Create custom tarfile extractall util to fix backward compatibility issue * Address review comments * fix logger.error statements * prepare release v2.212.0 * update development version to v2.212.1.dev0 * change: Update tblib constraint (#4452) * fix: make unit tests compatible with pytest-xdist (#4486) * fix: make unit tests compatible with pytest-xdist * fix failing test * feature: Add overriding logic in ModelBuilder when task is provided (#4460) * feat: Add Optional task to Model * Revert "feat: Add Optional task to Model" This reverts commit fd3e86b. * Add override logic in ModelBuilder with task provided * Adjusted formatting * Add extra unit tests for invalid inputs * Address PR comments * Add more test inputs to integration test * Add model_metadata field to ModelBuilder * Update doc * Update doc * Adjust formatting --------- Co-authored-by: Samrudhi Sharma <samruds@amazon.com> Co-authored-by: Xiong Zeng <xionzeng@amazon.com> * feature: Accept user-defined env variables for the entry-point (#4175) * fix: Move sagemaker pysdk version check after bootstrap in remote job (#4487) * change: enable github actions for PRs (#4489) * change: enable github actions for PRs * Update codebuild-ci.yml * trigger on pull_request_target * add source-version-override * fix permission * feature: Add ModelDataSource and SourceUri support for model package and while registering (#4492) Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> * feat: support JumpStart proprietary models (#4467) * feat: add proprietary manifest/specs parsing add unittests for test_cache small refactoring address comments and more unittests fix linting and fix more tests fix: pylint feat: JumpStartModel class for prop models * remove unused imports and fix docstyle * fix: remove unused args * fix: remove unused args * fix: more unused vars * fix: slow tests * fix: unittests * added more tests to cover some lines * remove estimator warn check * chore: address comments re performance * fix: address comments * complete list experience and other fixes * fix: pylint * add doc utils and fix pylint * fix: docstyle * fix: doc * fix: default payloads * fix: doc and tags and enums * fix: jumpstart doc * rename to open_weights and fix filtering * update filter name * doc update * fix: black * rename to proprietary model and fix unittests * address comments * fix: docstyle and flake8 * address more comments and fix doc * put back doc utils for future refactoring * add prop model title in doc * doc update --------- Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com> * chore: emit warning when no instance specific gated training env var is available, and raise exception when accept_eula flag is not supplied (#4485) * fix: raise exception when no instance specific gated training env var available * chore: raise client exception if accept_eula flag is not set for gated models * chore: address flake8 errors * chore: emit warning when instance type is chosen with no gated training artifacts * change: bump jinja2 to 3.1.3 in doc/requirments.txt (#4421) (#4423) * change: bump jinja2 to 3.1.3 in doc/requirments.txt (#4421) * change: bump jinja2 to 3.1.3 in doc/requirments.txt * Update requirements.txt * feature: TGI 1.4.0 (#4424) * documentation: fix the ClarifyCheckStep documentation to mention PDP (#4259) * documentation: fix the ClarifyCheckStep documentation to mention PDP support * fix: break the lines to meet pylint requirement --------- Co-authored-by: Shing Lyu <shinglyu@amazon.nl> * documentation: Explain the ClarifyCheckStep and QualityCheckStep parameters (#4261) * documentation: explain the ClarifyCheckStep and QualityCheckStep parameters * fix: remove trailing space --------- Co-authored-by: Shing Lyu <shinglyu@amazon.nl> * feat: Telemetry metrics (#4414) * Emit additional telemetry metrics * Fix unit tests * Emit endpoint failure to telemetry * Address PR Comments * Emit latency in telemetry * Address PR Comments * Addressed PR Comments * Address PR Comments * Fix tests * Fix integ tests --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> * documentation: change order of pipelines topics (#4427) * prepare release v2.208.0 * update development version to v2.208.1.dev0 * feature: AutoGluon 1.0.0 image_uris update (#4426) --------- Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> Co-authored-by: Jinyoung Lim <jj.lim418@gmail.com> Co-authored-by: Shing Lyu <shing.lyu@gmail.com> Co-authored-by: Shing Lyu <shinglyu@amazon.nl> Co-authored-by: Jonathan Makunga <54963715+makungaj1@users.noreply.github.com> Co-authored-by: Jonathan Makunga <makung@amazon.com> Co-authored-by: stacicho <stacicho@amazon.com> Co-authored-by: ci <ci> Co-authored-by: tonyhu <tonyhoo@users.noreply.github.com> * feat: add hub and hubcontent support in retrieval function for jumpstart model cache (#4438) * feat: jsch jumpstart estimator support (#4439) * Master jumpstart curated hub (#4464) * add hub_arn support for accept_types, content_types, serializers, deserializers, and predictor (#4463) * feature: JumpStart CuratedHub class creation and function definitions (#4448) * MultiPartCopy with Sync Algorithm (#4475) * first pass at sync function with util classes * adding tests and update clases * linting * file generator class inheritance * lint * multipart copy and algorithm updates * modularize sync * reformatting folders * testing for sync * do not tolerate vulnerable * remove prints * handle multithreading progress bar * update tests * optimize function and add hub bucket prefix * docstrings and linting * rebase with master * bad rebase * trying to fix codecov * uncomment codebuild-ci --------- Co-authored-by: ci <ci> Co-authored-by: Nikhil Kulkarni <knikhil29@gmail.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> Co-authored-by: Anton Repushko <repushko.a@gmail.com> Co-authored-by: Anton Repushko <repuanto@amazon.com> Co-authored-by: Sai Parthasarathy Miduthuri <54188298+saimidu@users.noreply.github.com> Co-authored-by: Rohan Gujarathi <gujarathi.rohan@gmail.com> Co-authored-by: Rohan Gujarathi <gujrohan@amazon.com> Co-authored-by: cansun <80425164+can-sun@users.noreply.github.com> Co-authored-by: Justin <justinm088@hotmail.com> Co-authored-by: evakravi <69981223+evakravi@users.noreply.github.com> Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com> Co-authored-by: gv <gverkes@users.noreply.github.com> Co-authored-by: akrishna1995 <38850354+akrishna1995@users.noreply.github.com> Co-authored-by: Ashwin Krishna <ashwikri@amazon.com> Co-authored-by: Samrudhi Sharma <154457034+samruds@users.noreply.github.com> Co-authored-by: adtian2 <55163384+adtian2@users.noreply.github.com> Co-authored-by: Andrew Tian <tinandr@amazon.com> Co-authored-by: Sirut Buasai <73297481+sirutBuasai@users.noreply.github.com> Co-authored-by: Danny Bushkanets <d.bushkanets@gmail.com> Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> Co-authored-by: xiongz945 <54782408+xiongz945@users.noreply.github.com> Co-authored-by: Samrudhi Sharma <samruds@amazon.com> Co-authored-by: Xiong Zeng <xionzeng@amazon.com> Co-authored-by: martinRenou <martin.renou@gmail.com> Co-authored-by: mrudulmn <161017394+mrudulmn@users.noreply.github.com> Co-authored-by: Haotian An <33510317+Captainia@users.noreply.github.com> Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com> Co-authored-by: Jinyoung Lim <jj.lim418@gmail.com> Co-authored-by: Shing Lyu <shing.lyu@gmail.com> Co-authored-by: Shing Lyu <shinglyu@amazon.nl> Co-authored-by: Jonathan Makunga <54963715+makungaj1@users.noreply.github.com> Co-authored-by: Jonathan Makunga <makung@amazon.com> Co-authored-by: stacicho <stacicho@amazon.com> Co-authored-by: tonyhu <tonyhoo@users.noreply.github.com>

* fix: make sure gpus are found in local_gpu run (#4384) * fix: make sure gpus are found in local_gpu run * fix: black formatting * fix: adjust unit test * feat: pin dll version to support python3.11 to the sdk (#4472) Co-authored-by: Ashwin Krishna <ashwikri@amazon.com> * fix: Skip No Canvas regions for test_deploy_best_candidate (#4477) * prepare release v2.211.0 * update development version to v2.211.1.dev0 * change: Enhance model builder selection logic to include model size (#4429) * change: Enhance model builder selection logic to include model size * Fix conflicts * Address PR comments * fix formatting * fix formatting of test * Fix token in tasks.json * Increase coverage for tests * fix formatting * Fix requirements * Import code instead of importing accelerate * Fix formatting * Setup dependencies * change: Upgrade smp to version 2.2 (#4479) * upgrading smp to version 2.2 * fixing linting issue * fixing syntax error with multiline if statement * upgrading smp to version 2.2 * fixing linting issue * fixing syntax error with multiline if statement * fixing formatting --------- Co-authored-by: Andrew Tian <tinandr@amazon.com> * feat: Update SM Python SDK for PT 2.2.0 SM DLC (#4481) * update pt2.2 sm training dlc pysdk * update pt2.2 sm inference dlc pysdk and region list * fix: Create custom tarfile extractall util to fix backward compatibility issue (#4476) * fix: Create custom tarfile extractall util to fix backward compatibility issue * Address review comments * fix logger.error statements * prepare release v2.212.0 * update development version to v2.212.1.dev0 * change: Update tblib constraint (#4452) * fix: make unit tests compatible with pytest-xdist (#4486) * fix: make unit tests compatible with pytest-xdist * fix failing test * feature: Add overriding logic in ModelBuilder when task is provided (#4460) * feat: Add Optional task to Model * Revert "feat: Add Optional task to Model" This reverts commit fd3e86b. * Add override logic in ModelBuilder with task provided * Adjusted formatting * Add extra unit tests for invalid inputs * Address PR comments * Add more test inputs to integration test * Add model_metadata field to ModelBuilder * Update doc * Update doc * Adjust formatting --------- Co-authored-by: Samrudhi Sharma <samruds@amazon.com> Co-authored-by: Xiong Zeng <xionzeng@amazon.com> * feature: Accept user-defined env variables for the entry-point (#4175) * fix: Move sagemaker pysdk version check after bootstrap in remote job (#4487) * change: enable github actions for PRs (#4489) * change: enable github actions for PRs * Update codebuild-ci.yml * trigger on pull_request_target * add source-version-override * fix permission * feature: Add ModelDataSource and SourceUri support for model package and while registering (#4492) Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> * feat: support JumpStart proprietary models (#4467) * feat: add proprietary manifest/specs parsing add unittests for test_cache small refactoring address comments and more unittests fix linting and fix more tests fix: pylint feat: JumpStartModel class for prop models * remove unused imports and fix docstyle * fix: remove unused args * fix: remove unused args * fix: more unused vars * fix: slow tests * fix: unittests * added more tests to cover some lines * remove estimator warn check * chore: address comments re performance * fix: address comments * complete list experience and other fixes * fix: pylint * add doc utils and fix pylint * fix: docstyle * fix: doc * fix: default payloads * fix: doc and tags and enums * fix: jumpstart doc * rename to open_weights and fix filtering * update filter name * doc update * fix: black * rename to proprietary model and fix unittests * address comments * fix: docstyle and flake8 * address more comments and fix doc * put back doc utils for future refactoring * add prop model title in doc * doc update --------- Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com> * chore: emit warning when no instance specific gated training env var is available, and raise exception when accept_eula flag is not supplied (#4485) * fix: raise exception when no instance specific gated training env var available * chore: raise client exception if accept_eula flag is not set for gated models * chore: address flake8 errors * chore: emit warning when instance type is chosen with no gated training artifacts * fix: sagemaker session region not being used (#4469) * fix: sagemaker session region not being used * chore: add unit tests * fix: remove all JUMPSTART_DEFAULT_REGION_NAME default arguments * chore: use get_region_fallback throughout * chore: remove unnecessary if statement * chore: remove unnecessary if statement (2) --------- Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> * fix: add PT 2.2 support for smdistributed, pytorchddp, and torch_distributed distributions (#4480) * Add support for smdistributed, pytorchddp, torch_distributed for PT 2.2 * formatting * formatting --------- Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com> * change: split coverage out from testenv in tox.ini (#4495) Co-authored-by: Ashwin Krishna <ashwikri@amazon.com> * change: add ci-health checks (#4493) * feat: tgi optimum 0.0.19, 0.0.20 releases (#4496) * feature: Add support for Streaming Inference (#4497) * feature: Add support for Streaming Inference * fix: codestyle-docs-test * fix: codestyle-docs-test * Add AutoML -> AutoMLV2 mapper (#4500) Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com> * Skip of tests which are long running and causing the ResourceLimitInUse exception (#4504) * Improvement of the tuner documentation (#4506) * prepare release v2.213.0 * update development version to v2.213.1.dev0 * fix:urge customers to install latest version (#4507) * fix: list jumpstart models with invalid version strings (#4511) * fix: list jumpstart models with invalid versions * docstyle * docstyle * pylint * add more test * fix * fix: skip failing pt test (#4512) * fix: skip failing pt test * black-format --------- Co-authored-by: gv <gverkes@users.noreply.github.com> Co-authored-by: akrishna1995 <38850354+akrishna1995@users.noreply.github.com> Co-authored-by: Ashwin Krishna <ashwikri@amazon.com> Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com> Co-authored-by: ci <ci> Co-authored-by: Samrudhi Sharma <154457034+samruds@users.noreply.github.com> Co-authored-by: adtian2 <55163384+adtian2@users.noreply.github.com> Co-authored-by: Andrew Tian <tinandr@amazon.com> Co-authored-by: Sirut Buasai <73297481+sirutBuasai@users.noreply.github.com> Co-authored-by: Danny Bushkanets <d.bushkanets@gmail.com> Co-authored-by: xiongz945 <54782408+xiongz945@users.noreply.github.com> Co-authored-by: Samrudhi Sharma <samruds@amazon.com> Co-authored-by: Xiong Zeng <xionzeng@amazon.com> Co-authored-by: martinRenou <martin.renou@gmail.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> Co-authored-by: mrudulmn <161017394+mrudulmn@users.noreply.github.com> Co-authored-by: Haotian An <33510317+Captainia@users.noreply.github.com> Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com> Co-authored-by: evakravi <69981223+evakravi@users.noreply.github.com> Co-authored-by: ruhanprasad <52712386+ruhanprasad@users.noreply.github.com> Co-authored-by: Mufaddal Rohawala <89424143+mufaddal-rohawala@users.noreply.github.com> Co-authored-by: Anton Repushko <repushko.a@gmail.com>

knikure requested a review from a team as a code owner March 5, 2024 06:28

knikure requested review from liujiaorr and removed request for a team March 5, 2024 06:28

knikure commented Mar 5, 2024

View reviewed changes

mufaddal-rohawala reviewed Mar 5, 2024

View reviewed changes

qidewenwhen reviewed Mar 5, 2024

View reviewed changes

src/sagemaker/utils.py Show resolved Hide resolved

qidewenwhen reviewed Mar 6, 2024

View reviewed changes

knikure force-pushed the fix-extractall branch from f758927 to 7a8b6a1 Compare March 6, 2024 02:57

knikure added 3 commits March 5, 2024 22:32

fix: Create custom tarfile extractall util to fix backward compatibil…

dbb82c1

…ity issue

Address review comments

fa3dfc2

fix logger.error statements

9db0539

knikure force-pushed the fix-extractall branch from 1781d1a to 9db0539 Compare March 6, 2024 06:33

knikure commented Mar 6, 2024

View reviewed changes

mufaddal-rohawala approved these changes Mar 6, 2024

View reviewed changes

knikure merged commit df2cc4d into aws:master Mar 6, 2024
7 of 8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Create custom tarfile extractall util to fix backward compatibility issue #4476

fix: Create custom tarfile extractall util to fix backward compatibility issue #4476

knikure commented Mar 5, 2024 •

edited

mufaddal-rohawala commented Mar 5, 2024

mufaddal-rohawala commented Mar 5, 2024

mufaddal-rohawala commented Mar 5, 2024

mufaddal-rohawala commented Mar 5, 2024

mufaddal-rohawala commented Mar 5, 2024

knikure left a comment

mufaddal-rohawala commented Mar 5, 2024

codecov bot commented Mar 5, 2024 •

edited

mufaddal-rohawala Mar 5, 2024

mufaddal-rohawala commented Mar 5, 2024

mufaddal-rohawala commented Mar 5, 2024

mufaddal-rohawala commented Mar 5, 2024

mufaddal-rohawala commented Mar 6, 2024

mufaddal-rohawala commented Mar 6, 2024

qidewenwhen Mar 6, 2024

mufaddal-rohawala commented Mar 6, 2024

mufaddal-rohawala commented Mar 6, 2024

mufaddal-rohawala commented Mar 6, 2024

mufaddal-rohawala commented Mar 6, 2024

mufaddal-rohawala commented Mar 6, 2024

mufaddal-rohawala commented Mar 6, 2024

mufaddal-rohawala commented Mar 6, 2024

mufaddal-rohawala commented Mar 6, 2024

mufaddal-rohawala commented Mar 6, 2024

mufaddal-rohawala commented Mar 6, 2024

knikure left a comment

diggerdan commented Mar 6, 2024

mufaddal-rohawala commented Mar 6, 2024

johnrwoolley commented Mar 7, 2024

	logger.debug(
	"Selecting TrainingInput's input_mode (%s) for TrainingInputMode.",
	inputs.config["InputMode"],
	)

fix: Create custom tarfile extractall util to fix backward compatibility issue #4476

fix: Create custom tarfile extractall util to fix backward compatibility issue #4476

Conversation

knikure commented Mar 5, 2024 • edited

Merge Checklist

General

Tests

mufaddal-rohawala commented Mar 5, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Mar 5, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Mar 5, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Mar 5, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Mar 5, 2024

AWS CodeBuild CI Report

knikure left a comment

Choose a reason for hiding this comment

mufaddal-rohawala commented Mar 5, 2024

AWS CodeBuild CI Report

codecov bot commented Mar 5, 2024 • edited

Codecov Report

mufaddal-rohawala Mar 5, 2024

Choose a reason for hiding this comment

mufaddal-rohawala commented Mar 5, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Mar 5, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Mar 5, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Mar 6, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Mar 6, 2024

AWS CodeBuild CI Report

qidewenwhen Mar 6, 2024

Choose a reason for hiding this comment

mufaddal-rohawala commented Mar 6, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Mar 6, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Mar 6, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Mar 6, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Mar 6, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Mar 6, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Mar 6, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Mar 6, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Mar 6, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Mar 6, 2024

AWS CodeBuild CI Report

knikure left a comment

Choose a reason for hiding this comment

diggerdan commented Mar 6, 2024

mufaddal-rohawala commented Mar 6, 2024

AWS CodeBuild CI Report

johnrwoolley commented Mar 7, 2024

knikure commented Mar 5, 2024 •

edited

codecov bot commented Mar 5, 2024 •

edited