Telemetry metrics #4414

makungaj1 · 2024-02-07T03:27:51Z

Issue #, if available:

Description of changes:
Emit the followings in Telemetry

Endpoint Arn
SageMaker Python SDK Version
Endpoint Failures
Latency

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

[ x] I have read the CONTRIBUTING doc
[ x] I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
[ x] I used the commit message format described in CONTRIBUTING
[x ] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
[ x] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

[ x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ x] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
[x ] I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

mufaddal-rohawala · 2024-02-07T04:25:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: bdd6c63
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-07T04:27:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: bdd6c63
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-07T04:29:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: bdd6c63
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-07T04:29:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: bdd6c63
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-07T05:27:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: bdd6c63
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2024-02-07T05:28:16Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (43cdadd) 86.82% compared to head (44e08d7) 86.82%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4414   +/-   ##
=======================================
  Coverage   86.82%   86.82%           
=======================================
  Files         386      386           
  Lines       35694    35710   +16     
=======================================
+ Hits        30990    31006   +16     
  Misses       4704     4704

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gwang111 · 2024-02-07T19:08:46Z

We should add @knikure as a reviewer. She's working on telemetry effort PySDK side. Lets get her input

gwang111 · 2024-02-07T19:10:43Z

setup.py

@@ -32,6 +32,21 @@ def read_version():
    return read("VERSION").strip()


+def pysdk_version():


This seems a little strange to include in the setup.py. Is this the best way to get the PySDK version?

I am still looking for a better way. Any suggestion here?

@gwang111 and @makungaj1 We don't need to create a function to just get SDK version. We can do something like -

import importlib_metadata SDK_VERSION=importlib_metadata.version("sagemaker")

Tagging @mohanasudhan to check if he approves to this.

You could try this:

SDK_VERSION = importlib_metadata.version("sagemaker")

sagemaker-python-sdk/src/sagemaker/user_agent.py

Line 21 in 87d661a

SDK_VERSION = importlib_metadata.version("sagemaker")

Curious, why do we need a function to pull the version? What is the problem with above listed option?

mufaddal-rohawala · 2024-02-07T19:58:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 641bb9d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-07T20:02:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 641bb9d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-07T20:03:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 641bb9d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-07T20:59:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 641bb9d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-07T21:16:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 641bb9d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

grenmester · 2024-02-07T22:41:12Z

tests/unit/test_session.py

@@ -3192,7 +3192,9 @@ def test_create_model_from_job_with_vpc_config_override(sagemaker_session):

 def test_endpoint_from_production_variants(sagemaker_session):
    ims = sagemaker_session
-    ims.sagemaker_client.describe_endpoint = Mock(return_value={"EndpointStatus": "InService"})
+    ims.sagemaker_client.describe_endpoint = Mock(
+        return_value={"EndpointStatus": "InService", "EndpointArn": "arn:aws:sagemaker:"}


nit: Could we use a full ARN like arn:aws:sagemaker:us-west-2:123456789012:endpoint/test

src/sagemaker/serve/utils/telemetry_logger.py

mufaddal-rohawala · 2024-02-07T23:51:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 6c43300
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

knikure · 2024-02-08T00:37:37Z

src/sagemaker/utils.py

@@ -1489,3 +1489,10 @@ def format_tags(tags: Tags) -> List[TagsDict]:
        return [{"Key": str(k), "Value": str(v)} for k, v in tags.items()]

    return tags
+
+
+def pysdk_version() -> str:


We don't need this too as suggested above

knikure · 2024-02-08T00:38:36Z

src/sagemaker/serve/utils/telemetry_logger.py

@@ -63,11 +64,15 @@ def wrapper(self, *args, **kwargs):
                f"{func_name}"
                f"&x-modelServer={MODEL_SERVER_TO_CODE[str(self.model_server)]}"
                f"&x-imageTag={image_uri_tail}"
+                f"&x-pySdkVersion={pysdk_version()}"


Create the constant SDK_VERSION and then reuse it wherever needed.

Will use the one from here sagemaker-python-sdk/src/sagemaker/user_agent.py

mufaddal-rohawala · 2024-02-08T00:43:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 6c43300
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-08T00:58:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 6c43300
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-08T01:13:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 6c43300
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-08T01:22:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 6c43300
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-12T23:51:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 30169b3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-13T00:24:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 30169b3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-13T00:25:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 30169b3
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-13T01:27:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 0c7d876
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-13T01:31:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 0c7d876
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

src/sagemaker/session.py

mufaddal-rohawala · 2024-02-13T02:36:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 1566935
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-13T02:44:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 1566935
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-13T03:08:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 1566935
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-13T03:36:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 1566935
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-13T04:23:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 1566935
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-13T05:29:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 44e08d7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-13T05:32:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 44e08d7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-13T05:49:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 44e08d7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-13T06:30:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 44e08d7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-13T07:25:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 44e08d7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

* change: bump jinja2 to 3.1.3 in doc/requirments.txt (#4421) * change: bump jinja2 to 3.1.3 in doc/requirments.txt * Update requirements.txt * feature: TGI 1.4.0 (#4424) * documentation: fix the ClarifyCheckStep documentation to mention PDP (#4259) * documentation: fix the ClarifyCheckStep documentation to mention PDP support * fix: break the lines to meet pylint requirement --------- Co-authored-by: Shing Lyu <shinglyu@amazon.nl> * documentation: Explain the ClarifyCheckStep and QualityCheckStep parameters (#4261) * documentation: explain the ClarifyCheckStep and QualityCheckStep parameters * fix: remove trailing space --------- Co-authored-by: Shing Lyu <shinglyu@amazon.nl> * feat: Telemetry metrics (#4414) * Emit additional telemetry metrics * Fix unit tests * Emit endpoint failure to telemetry * Address PR Comments * Emit latency in telemetry * Address PR Comments * Addressed PR Comments * Address PR Comments * Fix tests * Fix integ tests --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> * documentation: change order of pipelines topics (#4427) * prepare release v2.208.0 * update development version to v2.208.1.dev0 * feature: AutoGluon 1.0.0 image_uris update (#4426) --------- Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> Co-authored-by: Jinyoung Lim <jj.lim418@gmail.com> Co-authored-by: Shing Lyu <shing.lyu@gmail.com> Co-authored-by: Shing Lyu <shinglyu@amazon.nl> Co-authored-by: Jonathan Makunga <54963715+makungaj1@users.noreply.github.com> Co-authored-by: Jonathan Makunga <makung@amazon.com> Co-authored-by: stacicho <stacicho@amazon.com> Co-authored-by: ci <ci> Co-authored-by: tonyhu <tonyhoo@users.noreply.github.com>

) * change: bump jinja2 to 3.1.3 in doc/requirments.txt (aws#4421) * change: bump jinja2 to 3.1.3 in doc/requirments.txt * Update requirements.txt * feature: TGI 1.4.0 (aws#4424) * documentation: fix the ClarifyCheckStep documentation to mention PDP (aws#4259) * documentation: fix the ClarifyCheckStep documentation to mention PDP support * fix: break the lines to meet pylint requirement --------- Co-authored-by: Shing Lyu <shinglyu@amazon.nl> * documentation: Explain the ClarifyCheckStep and QualityCheckStep parameters (aws#4261) * documentation: explain the ClarifyCheckStep and QualityCheckStep parameters * fix: remove trailing space --------- Co-authored-by: Shing Lyu <shinglyu@amazon.nl> * feat: Telemetry metrics (aws#4414) * Emit additional telemetry metrics * Fix unit tests * Emit endpoint failure to telemetry * Address PR Comments * Emit latency in telemetry * Address PR Comments * Addressed PR Comments * Address PR Comments * Fix tests * Fix integ tests --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> * documentation: change order of pipelines topics (aws#4427) * prepare release v2.208.0 * update development version to v2.208.1.dev0 * feature: AutoGluon 1.0.0 image_uris update (aws#4426) --------- Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> Co-authored-by: Jinyoung Lim <jj.lim418@gmail.com> Co-authored-by: Shing Lyu <shing.lyu@gmail.com> Co-authored-by: Shing Lyu <shinglyu@amazon.nl> Co-authored-by: Jonathan Makunga <54963715+makungaj1@users.noreply.github.com> Co-authored-by: Jonathan Makunga <makung@amazon.com> Co-authored-by: stacicho <stacicho@amazon.com> Co-authored-by: ci <ci> Co-authored-by: tonyhu <tonyhoo@users.noreply.github.com>

* Emit additional telemetry metrics * Fix unit tests * Emit endpoint failure to telemetry * Address PR Comments * Emit latency in telemetry * Address PR Comments * Addressed PR Comments * Address PR Comments * Fix tests * Fix integ tests --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>

) * change: bump jinja2 to 3.1.3 in doc/requirments.txt (aws#4421) * change: bump jinja2 to 3.1.3 in doc/requirments.txt * Update requirements.txt * feature: TGI 1.4.0 (aws#4424) * documentation: fix the ClarifyCheckStep documentation to mention PDP (aws#4259) * documentation: fix the ClarifyCheckStep documentation to mention PDP support * fix: break the lines to meet pylint requirement --------- Co-authored-by: Shing Lyu <shinglyu@amazon.nl> * documentation: Explain the ClarifyCheckStep and QualityCheckStep parameters (aws#4261) * documentation: explain the ClarifyCheckStep and QualityCheckStep parameters * fix: remove trailing space --------- Co-authored-by: Shing Lyu <shinglyu@amazon.nl> * feat: Telemetry metrics (aws#4414) * Emit additional telemetry metrics * Fix unit tests * Emit endpoint failure to telemetry * Address PR Comments * Emit latency in telemetry * Address PR Comments * Addressed PR Comments * Address PR Comments * Fix tests * Fix integ tests --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> * documentation: change order of pipelines topics (aws#4427) * prepare release v2.208.0 * update development version to v2.208.1.dev0 * feature: AutoGluon 1.0.0 image_uris update (aws#4426) --------- Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> Co-authored-by: Jinyoung Lim <jj.lim418@gmail.com> Co-authored-by: Shing Lyu <shing.lyu@gmail.com> Co-authored-by: Shing Lyu <shinglyu@amazon.nl> Co-authored-by: Jonathan Makunga <54963715+makungaj1@users.noreply.github.com> Co-authored-by: Jonathan Makunga <makung@amazon.com> Co-authored-by: stacicho <stacicho@amazon.com> Co-authored-by: ci <ci> Co-authored-by: tonyhu <tonyhoo@users.noreply.github.com>

* prepare release v2.210.0 * update development version to v2.210.1.dev0 * feat: Add new Triton DLC URIs (#4432) * Add new Triton DLC URIs * Update according to black and pylint * feat: Support selective pipeline execution between function step and regular step (#4392) * feat: Add AutoMLV2 support (#4461) * Add AutoMLV2 support * Improvements of the integration tests --------- Co-authored-by: Anton Repushko <repuanto@amazon.com> * feature: Add TensorFlow 2.14 image configs (#4446) * fix: remove enable_network_isolation from the python doc (#4465) Co-authored-by: Rohan Gujarathi <gujrohan@amazon.com> * doc: Add doc for new feature processor APIs and classes (#4250) * fix: properly close sagemaker config file after loading config (#4457) Closes #4456 * feat: instance specific jumpstart host requirements (#4397) * feat: instance specific jumpstart host requirements * chore: add js support for copies resource requirement, enforce coupling with ResourceRequirements class * fix: typing * fix: pylint * change: Bump Apache Airflow version to 2.8.2 (#4470) * Update tox.ini * Update test_requirements.txt * fix: make sure gpus are found in local_gpu run (#4384) * fix: make sure gpus are found in local_gpu run * fix: black formatting * fix: adjust unit test * feat: pin dll version to support python3.11 to the sdk (#4472) Co-authored-by: Ashwin Krishna <ashwikri@amazon.com> * fix: Skip No Canvas regions for test_deploy_best_candidate (#4477) * prepare release v2.211.0 * update development version to v2.211.1.dev0 * change: Enhance model builder selection logic to include model size (#4429) * change: Enhance model builder selection logic to include model size * Fix conflicts * Address PR comments * fix formatting * fix formatting of test * Fix token in tasks.json * Increase coverage for tests * fix formatting * Fix requirements * Import code instead of importing accelerate * Fix formatting * Setup dependencies * change: Upgrade smp to version 2.2 (#4479) * upgrading smp to version 2.2 * fixing linting issue * fixing syntax error with multiline if statement * upgrading smp to version 2.2 * fixing linting issue * fixing syntax error with multiline if statement * fixing formatting --------- Co-authored-by: Andrew Tian <tinandr@amazon.com> * feat: Update SM Python SDK for PT 2.2.0 SM DLC (#4481) * update pt2.2 sm training dlc pysdk * update pt2.2 sm inference dlc pysdk and region list * fix: Create custom tarfile extractall util to fix backward compatibility issue (#4476) * fix: Create custom tarfile extractall util to fix backward compatibility issue * Address review comments * fix logger.error statements * prepare release v2.212.0 * update development version to v2.212.1.dev0 * change: Update tblib constraint (#4452) * fix: make unit tests compatible with pytest-xdist (#4486) * fix: make unit tests compatible with pytest-xdist * fix failing test * feature: Add overriding logic in ModelBuilder when task is provided (#4460) * feat: Add Optional task to Model * Revert "feat: Add Optional task to Model" This reverts commit fd3e86b. * Add override logic in ModelBuilder with task provided * Adjusted formatting * Add extra unit tests for invalid inputs * Address PR comments * Add more test inputs to integration test * Add model_metadata field to ModelBuilder * Update doc * Update doc * Adjust formatting --------- Co-authored-by: Samrudhi Sharma <samruds@amazon.com> Co-authored-by: Xiong Zeng <xionzeng@amazon.com> * feature: Accept user-defined env variables for the entry-point (#4175) * fix: Move sagemaker pysdk version check after bootstrap in remote job (#4487) * change: enable github actions for PRs (#4489) * change: enable github actions for PRs * Update codebuild-ci.yml * trigger on pull_request_target * add source-version-override * fix permission * feature: Add ModelDataSource and SourceUri support for model package and while registering (#4492) Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> * feat: support JumpStart proprietary models (#4467) * feat: add proprietary manifest/specs parsing add unittests for test_cache small refactoring address comments and more unittests fix linting and fix more tests fix: pylint feat: JumpStartModel class for prop models * remove unused imports and fix docstyle * fix: remove unused args * fix: remove unused args * fix: more unused vars * fix: slow tests * fix: unittests * added more tests to cover some lines * remove estimator warn check * chore: address comments re performance * fix: address comments * complete list experience and other fixes * fix: pylint * add doc utils and fix pylint * fix: docstyle * fix: doc * fix: default payloads * fix: doc and tags and enums * fix: jumpstart doc * rename to open_weights and fix filtering * update filter name * doc update * fix: black * rename to proprietary model and fix unittests * address comments * fix: docstyle and flake8 * address more comments and fix doc * put back doc utils for future refactoring * add prop model title in doc * doc update --------- Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com> * chore: emit warning when no instance specific gated training env var is available, and raise exception when accept_eula flag is not supplied (#4485) * fix: raise exception when no instance specific gated training env var available * chore: raise client exception if accept_eula flag is not set for gated models * chore: address flake8 errors * chore: emit warning when instance type is chosen with no gated training artifacts * change: bump jinja2 to 3.1.3 in doc/requirments.txt (#4421) (#4423) * change: bump jinja2 to 3.1.3 in doc/requirments.txt (#4421) * change: bump jinja2 to 3.1.3 in doc/requirments.txt * Update requirements.txt * feature: TGI 1.4.0 (#4424) * documentation: fix the ClarifyCheckStep documentation to mention PDP (#4259) * documentation: fix the ClarifyCheckStep documentation to mention PDP support * fix: break the lines to meet pylint requirement --------- Co-authored-by: Shing Lyu <shinglyu@amazon.nl> * documentation: Explain the ClarifyCheckStep and QualityCheckStep parameters (#4261) * documentation: explain the ClarifyCheckStep and QualityCheckStep parameters * fix: remove trailing space --------- Co-authored-by: Shing Lyu <shinglyu@amazon.nl> * feat: Telemetry metrics (#4414) * Emit additional telemetry metrics * Fix unit tests * Emit endpoint failure to telemetry * Address PR Comments * Emit latency in telemetry * Address PR Comments * Addressed PR Comments * Address PR Comments * Fix tests * Fix integ tests --------- Co-authored-by: Jonathan Makunga <makung@amazon.com> Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> * documentation: change order of pipelines topics (#4427) * prepare release v2.208.0 * update development version to v2.208.1.dev0 * feature: AutoGluon 1.0.0 image_uris update (#4426) --------- Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> Co-authored-by: Jinyoung Lim <jj.lim418@gmail.com> Co-authored-by: Shing Lyu <shing.lyu@gmail.com> Co-authored-by: Shing Lyu <shinglyu@amazon.nl> Co-authored-by: Jonathan Makunga <54963715+makungaj1@users.noreply.github.com> Co-authored-by: Jonathan Makunga <makung@amazon.com> Co-authored-by: stacicho <stacicho@amazon.com> Co-authored-by: ci <ci> Co-authored-by: tonyhu <tonyhoo@users.noreply.github.com> * feat: add hub and hubcontent support in retrieval function for jumpstart model cache (#4438) * feat: jsch jumpstart estimator support (#4439) * Master jumpstart curated hub (#4464) * add hub_arn support for accept_types, content_types, serializers, deserializers, and predictor (#4463) * feature: JumpStart CuratedHub class creation and function definitions (#4448) * MultiPartCopy with Sync Algorithm (#4475) * first pass at sync function with util classes * adding tests and update clases * linting * file generator class inheritance * lint * multipart copy and algorithm updates * modularize sync * reformatting folders * testing for sync * do not tolerate vulnerable * remove prints * handle multithreading progress bar * update tests * optimize function and add hub bucket prefix * docstrings and linting * rebase with master * bad rebase * trying to fix codecov * uncomment codebuild-ci --------- Co-authored-by: ci <ci> Co-authored-by: Nikhil Kulkarni <knikhil29@gmail.com> Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com> Co-authored-by: Anton Repushko <repushko.a@gmail.com> Co-authored-by: Anton Repushko <repuanto@amazon.com> Co-authored-by: Sai Parthasarathy Miduthuri <54188298+saimidu@users.noreply.github.com> Co-authored-by: Rohan Gujarathi <gujarathi.rohan@gmail.com> Co-authored-by: Rohan Gujarathi <gujrohan@amazon.com> Co-authored-by: cansun <80425164+can-sun@users.noreply.github.com> Co-authored-by: Justin <justinm088@hotmail.com> Co-authored-by: evakravi <69981223+evakravi@users.noreply.github.com> Co-authored-by: Kalyani Nikure <110067132+knikure@users.noreply.github.com> Co-authored-by: gv <gverkes@users.noreply.github.com> Co-authored-by: akrishna1995 <38850354+akrishna1995@users.noreply.github.com> Co-authored-by: Ashwin Krishna <ashwikri@amazon.com> Co-authored-by: Samrudhi Sharma <154457034+samruds@users.noreply.github.com> Co-authored-by: adtian2 <55163384+adtian2@users.noreply.github.com> Co-authored-by: Andrew Tian <tinandr@amazon.com> Co-authored-by: Sirut Buasai <73297481+sirutBuasai@users.noreply.github.com> Co-authored-by: Danny Bushkanets <d.bushkanets@gmail.com> Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> Co-authored-by: xiongz945 <54782408+xiongz945@users.noreply.github.com> Co-authored-by: Samrudhi Sharma <samruds@amazon.com> Co-authored-by: Xiong Zeng <xionzeng@amazon.com> Co-authored-by: martinRenou <martin.renou@gmail.com> Co-authored-by: mrudulmn <161017394+mrudulmn@users.noreply.github.com> Co-authored-by: Haotian An <33510317+Captainia@users.noreply.github.com> Co-authored-by: liujiaor <128006184+liujiaorr@users.noreply.github.com> Co-authored-by: Jinyoung Lim <jj.lim418@gmail.com> Co-authored-by: Shing Lyu <shing.lyu@gmail.com> Co-authored-by: Shing Lyu <shinglyu@amazon.nl> Co-authored-by: Jonathan Makunga <54963715+makungaj1@users.noreply.github.com> Co-authored-by: Jonathan Makunga <makung@amazon.com> Co-authored-by: stacicho <stacicho@amazon.com> Co-authored-by: tonyhu <tonyhoo@users.noreply.github.com>

Emit additional telemetry metrics

bdd6c63

makungaj1 requested a review from a team as a code owner February 7, 2024 03:27

makungaj1 requested review from mohanasudhan and removed request for a team February 7, 2024 03:27

Fix unit tests

641bb9d

gwang111 reviewed Feb 7, 2024

View reviewed changes

grenmester reviewed Feb 7, 2024

View reviewed changes

src/sagemaker/serve/utils/telemetry_logger.py Show resolved Hide resolved

Merge branch 'master' into master

6c43300

benieric self-assigned this Feb 7, 2024

knikure reviewed Feb 8, 2024

View reviewed changes

Emit endpoint failure to telemetry

a616b6f

Merge branch 'master' into master

0c7d876

Fix integ tests

1566935

makungaj1 commented Feb 13, 2024

View reviewed changes

src/sagemaker/session.py Show resolved Hide resolved

src/sagemaker/session.py Show resolved Hide resolved

Merge branch 'master' into master

44e08d7

knikure approved these changes Feb 13, 2024

View reviewed changes

knikure approved these changes Feb 14, 2024

View reviewed changes

knikure merged commit fd9a528 into aws:master Feb 14, 2024
6 checks passed

		@@ -32,6 +32,21 @@ def read_version():
		return read("VERSION").strip()


		def pysdk_version():

Telemetry metrics #4414

Telemetry metrics #4414

Conversation

makungaj1 commented Feb 7, 2024 • edited

Merge Checklist

General

Tests

mufaddal-rohawala commented Feb 7, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Feb 7, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Feb 7, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Feb 7, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Feb 7, 2024

AWS CodeBuild CI Report

codecov-commenter commented Feb 7, 2024 • edited

Codecov Report

gwang111 commented Feb 7, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mufaddal-rohawala commented Feb 7, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Feb 7, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Feb 7, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Feb 7, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Feb 7, 2024

AWS CodeBuild CI Report

Choose a reason for hiding this comment

mufaddal-rohawala commented Feb 7, 2024

AWS CodeBuild CI Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mufaddal-rohawala commented Feb 8, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Feb 8, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Feb 8, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Feb 8, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Feb 12, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Feb 13, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Feb 13, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Feb 13, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Feb 13, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Feb 13, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Feb 13, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Feb 13, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Feb 13, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Feb 13, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Feb 13, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Feb 13, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Feb 13, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Feb 13, 2024

AWS CodeBuild CI Report

mufaddal-rohawala commented Feb 13, 2024

AWS CodeBuild CI Report

makungaj1 commented Feb 7, 2024 •

edited

codecov-commenter commented Feb 7, 2024 •

edited