feat: New DisableFunctionDefaultPermissions property to block the creation of permissions resource from SAM API Auth #2885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaythapa
changed the title
aaythapa
changed the title
ssenchenko
approved these changes
Feb 10, 2023
aaythapa
changed the title
hoffa
reviewed
Feb 10, 2023
hoffa
reviewed
Feb 10, 2023
hoffa
reviewed
Feb 10, 2023
tests/translator/input/api_rest_auth_disable_default_function_permissions.yaml
Outdated
Show resolved
Hide resolved
hoffa
reviewed
Feb 13, 2023
hoffa
approved these changes
Feb 13, 2023
hoffa
reviewed
Feb 13, 2023
aaythapa
changed the title
aahung
approved these changes
Feb 15, 2023
hoffa
approved these changes
Feb 15, 2023
Closed
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available
#1656
Description of changes
A new opt-in boolean property
DisableFunctionDefaultPermissionsadded to the lambda authorizers (LambdaRequestAuthorizer and LambdaTokenAuthorizer) in SAM API that will block the creation of theAWS::Lambda::Permissionsresource that allows the API to invoke the authorizer function (its not created for the Cognito authorizer).The type changes may make the PR a bit confusing to review so the main changes are in
api_generator.pyandapigateway.pyDescription of how you validated changes
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam initthrough aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.