feat: Add EnableFunctionDefaultPermissions property to HTTP Api #3001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoffa
reviewed
Mar 6, 2023
ssenchenko
approved these changes
Mar 6, 2023
hoffa
reviewed
Mar 7, 2023
hoffa
reviewed
Mar 7, 2023
hoffa
reviewed
Mar 7, 2023
hoffa
reviewed
Mar 9, 2023
aaythapa
changed the title
ssenchenko
approved these changes
Mar 10, 2023
hoffa
reviewed
Mar 13, 2023
hoffa
approved these changes
Mar 13, 2023
hoffa
reviewed
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available
#2933
Description of changes
Added the
EnableFunctionDefaultPermissions(related pr: #2885) to SAM Http Api. By default, HTTP Api doesn't create the permissions resource that allows the API to invoke the lambda authorizer so this property will be False by default. When its set to True it'll create the permissions resource.Description of how you validated changes
Ran a test with the property set to false and without the property. Compared outputs and made sure only change was that the permissions resource was added. Deployed a template with SAM Http Api with the permission resource and made sure the API could invoke the authorizer.
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam initthrough aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.