Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Make transform test error json easier to diff/review #2968

Merged

Conversation

aahung
Copy link
Contributor

@aahung aahung commented Feb 27, 2023

Issue #, if available

Description of changes

When reviewing #2966, the diff is impossible to spot (see #2966 (comment))

Auto add a new key "_autoGeneratedBreakdownErrorMessage" that is multi-line so it is easy to diff/review.

Description of how you validated changes

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aahung aahung requested a review from a team as a code owner February 27, 2023 21:57
@aahung aahung enabled auto-merge (squash) February 27, 2023 22:03
Copy link
Contributor

@aaythapa aaythapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@aahung aahung merged commit 6bb9d53 into aws:develop Feb 27, 2023
@aahung aahung deleted the make-transform-output-error-message-easy-to-review branch February 27, 2023 22:04
GavinZZ pushed a commit to GavinZZ/serverless-application-model that referenced this pull request Mar 2, 2023
GavinZZ pushed a commit to GavinZZ/serverless-application-model that referenced this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants