feat: Apply Resource Validator on SAM GraphQL Resources #2985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoffa
reviewed
Mar 1, 2023
pradrx
reviewed
Mar 1, 2023
samtranslator/internal/schema_source/aws_serverless_graphqlapi.py
Outdated
Show resolved
Hide resolved
GavinZZ
force-pushed
the
resource_validator_with_graphql
branch
from
8385b44
to
58be7ab
Compare
GavinZZ
force-pushed
the
resource_validator_with_graphql
branch
from
58be7ab
to
73d48fc
Compare
GavinZZ
changed the title
hoffa
approved these changes
Mar 2, 2023
|
The error messages are kinda hard to review. Can we integrate with this change so it's easier to review? |
Going to do that in a separate PR. This branch |
xazhao
approved these changes
Mar 2, 2023
aahung
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available
Description of changes
Use resource validator as a runtime check on nested properties. No need to use
sam_expectanymore.Description of how you validated changes
All tests passed
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam initthrough aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.