Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert lambda nodejs18.x upgrade #3326

Merged
merged 5 commits into from
Aug 29, 2023

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Aug 29, 2023

Issue #, if available

Description of changes

Move out failed EB test to a new test suite and explicitly skip the test to see if it makes a difference.

In last week, we updated nodejs version to 18.x. However it seems that upgrade is not as simple as expected. Integration tests failed due to "Error: Cannot find module 'aws-sdk'\nRequire stack:\n- /var/task/index.js\n- /var/runtime/index.mjs".

If your lambda runtime is nodejs18.x my understanding is that SDK v2 is not included in the runtime.

So, the best solution would be to switch to v3 SDK https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/

Description of how you validated changes

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@GavinZZ GavinZZ requested a review from a team as a code owner August 29, 2023 18:26
@GavinZZ GavinZZ merged commit 263a330 into aws:develop Aug 29, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants