-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(policy-template): add mobile analytics targeting policy templates #408
Merged
brettstack
merged 5 commits into
aws:develop
from
simalexan:feat/mobile-analytics-targeting-policy-templates
May 23, 2018
Merged
feat(policy-template): add mobile analytics targeting policy templates #408
brettstack
merged 5 commits into
aws:develop
from
simalexan:feat/mobile-analytics-targeting-policy-templates
May 23, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reviewing now; expect to get back to the group in a day or two |
@salmanap Thank you very much in advance! |
brettstack
previously approved these changes
May 22, 2018
salmanap
previously approved these changes
May 23, 2018
brettstack
approved these changes
May 23, 2018
salmanap
approved these changes
May 23, 2018
Amazing! 👍 thank you ! |
jbasden
pushed a commit
that referenced
this pull request
Jul 25, 2018
This commit essentially copies the pattern of commit #408 to add a policy template that permits calling the filter log events cloudwatch API.
jbasden
pushed a commit
that referenced
this pull request
Jul 25, 2018
This commit essentially copies the pattern of commit #408 to add a policy template that permits calling the filter log events cloudwatch API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.