Add FilterLogEvents policy to policy templates. #523
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit essentially copies the pattern of commit #408 to add a policy template that permits calling the filter log events cloudwatch API.
Instead of using "Resource": "*", this commit changes the resource field to use only the Log Group specified.
ylynn
reviewed
Jul 26, 2018
| @@ -1239,6 +1239,34 @@ | |||
| } | |||
| ] | |||
| } | |||
| }, | |||
| "FilterLogEventsPolicy": { | |||
| "Description": "Gives permission to filter Log Events from any Log Group", | |||
There was a problem hiding this comment.
Update the description since you change the Resource to scope down to one log group.
| ], | ||
| "Resource": { | ||
| "Fn::Sub": [ | ||
| "arn:${AWS::Partition}:logs:${AWS::Region}:${AWS::Account}:log-group:${logGroupName}*", |
There was a problem hiding this comment.
Do you need the "*" at the end? You can try the policy definition in your own template to figure out.
There was a problem hiding this comment.
I put it there because of the lambda invoke example I was following. I don't believe it is needed though.
added 2 commits
July 26, 2018 10:24
This commit scopes down the access for the filter log events policy by removing the trailing star from the end of the resource field.
These whitespace changes came from Atom's default settings, and were unintentional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit essentially copies the pattern of commit #408
to add a policy template that permits calling the
filter log events cloudwatch API.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.