Fix handling scalar DependsOn values of S3 buckets #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like tests passed for Python 3.6, but not for Python 2.7. I tested on Python 2.7 locally, and everything passed. I may need help figuring out why the tests failed in CI... |
|
Oh... I thought I was testing on python 2.7 locally, but turns out I wasn't. I'll make sure next time :). |
DependsOn values can be either scalar strings or lists of strings. This change fixes handling when an S3 bucket in an input template has a scalar string value for DependsOn.
txase
force-pushed
the
fixBucketDependsOn
branch
from
a29d944
to
c917e4f
Compare
sanathkr
approved these changes
Jul 12, 2018
There was a problem hiding this comment.
LGTM. Thanks for identifying the problem and fixing this! @brettstack need your review :)
brettstack
approved these changes
Jul 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
DependsOn values can be either scalar strings or lists of strings. This
change fixes handling when an S3 bucket in an input template has a
scalar string value for DependsOn.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.