Added two new policy templates for SSM Parameter Store. #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added parameters for the environment variables in Splunk Example apps. - Added parameter for the SQS Poller queue url in that example app.
- Per issue aws#603 - Added it to all_policy_template test as well.
keetonian
reviewed
Oct 15, 2018
- Updated examples/apps/sqs-poller to add the .com.cn domain into the regex. - Added GetParameter to the policy templates. I'm not sure what the difference between GetParameter and GetParameters is, but they both seem to be used for different calls.
brettstack
reviewed
Jan 22, 2019
jlhood
suggested changes
Jan 29, 2019
There was a problem hiding this comment.
@RobRoseKnows really appreciate you submitting this PR! We've needed a policy template for retrieving SSM parameters for a little while now. Please merge in the latest changes from the develop branch and address my comments and we'll get this merged in. Thanks so much!
- Renamed DecodeSSMParameterPolicy to SSMParameterReadPolicy - Removed DecodeSSMParameterCusomKeyPolicy
Codecov Report
@@ Coverage Diff @@
## develop #625 +/- ##
===========================================
- Coverage 94.71% 94.22% -0.49%
===========================================
Files 67 67
Lines 2950 2685 -265
Branches 578 478 -100
===========================================
- Hits 2794 2530 -264
- Misses 78 80 +2
+ Partials 78 75 -3
Continue to review full report at Codecov.
|
jlhood
approved these changes
Feb 1, 2019
brettstack
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: #603
Description of changes: Added two new policy templates:
DecodeSSMParameterPolicyandDecodeSSMParameterCustomKeyPolicy. Also added parameters for the SQS queue and Splunk environment variables in two of the example apps. Kinda forgot I did that. 😅By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.