Add time.Duration to the list of Go Stdlib Types #515
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucix-aws
reviewed
Jun 4, 2024
| @@ -35,6 +35,7 @@ public static final class Context { | |||
|
|
|||
| public static final class Time { | |||
| public static final Symbol Time = SmithyGoDependency.TIME.pointableSymbol("Time"); | |||
| public static final Symbol Duration = SmithyGoDependency.TIME.valueSymbol("Duration"); | |||
There was a problem hiding this comment.
FWIW we've kind of stopped doing this because there are just too many -- instead we just started calling these directly, and we added some helpers so you can do stuff like
SmithyGoDependency.TIME.struct("Time")
This is fine though
There was a problem hiding this comment.
Got it, nah I rather do it The Right Way ™
Will close the PR
lucix-aws
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Adds
time.Durationto the list of Go standard types. This will be used by later PRsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.