Revert "Revert "Parse .xml snippet files in xi:include"" #6670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e36f582.
Laren-AWS
added
Bug
ford-at-aws
added
On Call Review complete
ford-at-aws
approved these changes
Jul 18, 2024
ford-at-aws
deleted the
revert-6668-revert-6661-feat/zonbook-xml-snippet-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #6668
This change is required to render the CLI examples correctly in the documentation.
The "missing hasSuffix" error you saw on 6668 was caused by your workspace being out of sync on the backend. If you sync everything and build with this unrevert, it should build correctly.