Make offline ER us total batch size in first update #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)src/renate/updaters/experimental/offline_er.py
|
wistuba
reviewed
Aug 17, 2023
| @@ -83,6 +84,21 @@ def train_dataloader(self) -> DataLoader: | |||
| pin_memory=True, | |||
| collate_fn=self._train_collate_fn, | |||
| ) | |||
| else: | |||
| # Manually create a dataloader for the current task with total batch size. | |||
There was a problem hiding this comment.
Can we reuse the code instead of overriding it?
self._batch_size += self._memory_batch_size
loaders["current_task"] = super().train_dataloader()
There was a problem hiding this comment.
I can do something like that if you prefer it. We would have to undo the change after creating the data loader though.
wistuba
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offline ER currently uses only
batch_sizein the first model update. This PR makes it usebatch_size + memory_batch_sizeto be comparable to joint training, et cetera.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.