Update add value #21
Merged
Update add value #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
verdimrc
added a commit
that referenced
this pull request
Sep 13, 2022
- Change signature: episode_identifier defaults to non-empty string - Remove (1-alpha) term, in-line with PR #21 - Update test acceptance criteria, and make sure to cover the case where df already has value which is going to be over-written.
verdimrc
force-pushed
the
update-add-value
branch
from
a0e547e
to
da3d76e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes: Remove the smoothing term (1-alpha) in the add_value() function.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.