Skip to content

Commit

Permalink
Merge pull request #580 from ginglis13/update-dockerfile-go
Browse files Browse the repository at this point in the history
fix: upgrade Dockerfile to go 1.19
  • Loading branch information
ginglis13 committed Aug 2, 2023
2 parents 44fa0cd + 71ce3b1 commit 5c087f3
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
8 changes: 7 additions & 1 deletion .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,13 @@ jobs:
with:
go-version: ${{ matrix.go }}
- run: make get-deps
if: ${{ matrix.go >= '1.17' }}
if: ${{ matrix.go >= '1.19' }}

# test Dockerfile build on Linux. macOS runners do not ship with Docker
# installed by default whereas Ubuntu runners do.
- name: Build in Dockerfile
run: make docker
if: ${{ matrix.os == 'ubuntu-22.04' }}

# Apple Silicon is not supported by Go < 1.16.
# https://go.dev/blog/go1.16
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# ANY KIND, either express or implied. See the License for the specific
# language governing permissions and limitations under the License.

FROM golang:1.15
FROM golang:1.19

WORKDIR /go/src/github.com/awslabs/amazon-ecr-credential-helper

Expand Down

0 comments on commit 5c087f3

Please sign in to comment.