Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for ECR Public #253

Merged
merged 3 commits into from Feb 11, 2021
Merged

Support for ECR Public #253

merged 3 commits into from Feb 11, 2021

Conversation

samuelkarp
Copy link
Contributor

Issue #, if available:
Fixes #248
Depends on #252

Description of changes:
This set of commits adds support for ECR Public. Note that it depends on #252, so you can skip those commits when reviewing this one (or they'll disappear from the diff when we merge that PR).

ECR Public credentials are cached and returned by the list command by default.

/cc @micahhausler

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

rpnguyen
rpnguyen approved these changes Dec 24, 2020
View reviewed changes
Copy link

@rpnguyen rpnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the quick turnaround, lgtm :shipit:

@PatrickXYS PatrickXYS mentioned this pull request Dec 26, 2020
Closed
@PatrickXYS
Copy link

@samuelkarp Any updates here, looks like the test failed for dependencies?

@samuelkarp
Copy link
Contributor Author

Any updates here, looks like the test failed for dependencies?

@PatrickXYS Considering I've been on vacation since right after opening this PR, no.

I don't currently have access to a Mac. It looks like an update to golang.org/x/sys is incompatible with Go 1.11 on Mac OS 10.15. We'll need to figure out whether to roll-back the update to that dependency or drop support for Go 1.11 on Mac OS 10.15.

@kzys
Copy link
Contributor

kzys commented Jan 5, 2021 •
edited

I'm inclined to drop Go 1.11 support in macOS and other OSes.

  • The Go team no longer supports Go 1.11.
  • Debian 10 (buster) has Go 1.11 but newer versions (1.13 and 1.14) are available in buster-backports.
  • Amazon Linux 2 has Go 1.13.

What do you think? Are there other places where customers have to use Go 1.11?

jahkeup
jahkeup reviewed Jan 5, 2021
View reviewed changes
Copy link
Member

@jahkeup jahkeup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still reading through, flushing minor nits for now.

ecr-login/api/client.go Outdated Show resolved Hide resolved
ecr-login/api/client.go Outdated Show resolved Hide resolved
@samuelkarp
Copy link
Contributor Author

I'm inclined to drop Go 1.11 support in macOS and other OSes.

@kzys I'm comfortable with that proposal. I think the only thing that needs to be updated is the GitHub actions workflow as the readme already recommends 1.12+ (though possibly we could bump that up to 1.14+ as well). My preference would be to have that change come in as a separate PR and then rebase this one on top.

kzys added a commit to kzys/amazon-ecr-credential-helper that referenced this pull request Jan 5, 2021
@kzys
Drop Go 1.11 support
79d64d3 
This change removes Go 1.11 from GitHub Actions to unblock awslabs#253.

Go 1.11 doesn't work on macOS 10.05 after upgrading golang.org/x/sys.
While we could downgrade golang.org/x/sys, Go 1.11 is no longer
supported by the Go team and most OSes tend to have newer Go packages.

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
@kzys kzys mentioned this pull request Jan 5, 2021
Merged
samuelkarp
samuelkarp commented Jan 6, 2021
View reviewed changes
ecr-login/api/client.go Outdated Show resolved Hide resolved
@theofpa theofpa mentioned this pull request Jan 24, 2021
Merged
1 task
@samuelkarp samuelkarp force-pushed the ecr-public branch 2 times, most recently from 2b500b9 to 952353a Compare February 11, 2021 18:32
kzys
kzys reviewed Feb 11, 2021
View reviewed changes
ecr-login/api/client.go Outdated Show resolved Hide resolved
ecr-login/api/client.go Outdated Show resolved Hide resolved
kzys
kzys approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samuelkarp samuelkarp merged commit 6ddba75 into awslabs:master Feb 11, 2021
@samuelkarp samuelkarp deleted the ecr-public branch February 11, 2021 18:57
@samuelkarp samuelkarp added this to the 0.5.0 milestone Feb 13, 2021
@samuelkarp samuelkarp mentioned this pull request Feb 16, 2021
Merged
@theofpa theofpa mentioned this pull request Feb 22, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahkeup jahkeup jahkeup left review comments

@kzys kzys kzys approved these changes

@rpnguyen rpnguyen rpnguyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add Support for Public ECR
5 participants
@samuelkarp @PatrickXYS @kzys @rpnguyen @jahkeup