Migrate to AWS SDK v2 #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzys
approved these changes
Jul 19, 2021
|
Oh by the way, I think the third party license file needs to be updated, I wasn't entirely sure how to format it. |
|
Bump |
|
@christopher-dG I can take a look the license file part. Can you squash the vendor commit and the revendor commit into one? They don't have to be separate, I think. I'm going to remove Go 1.12 in #291. The version is no longer supported by the Go team. |
christopher-dG
force-pushed
the
cdg/awsv2
branch
from
c4d0f50
to
a97ae4b
Compare
|
bump! |
|
Looks good to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Closes #282, I think it might also solve a few other auth-related issues in this repo.
Description of changes:
AWS_SDK_LOAD_CONFIGis gone, since I couldn't find any mention it in SDK v2. It's always enabled now.I have confirmed this works for my own use cases (assuming a role via EC2 instance metadata with a config profile).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.