Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker build based on alpine #29

Closed
wants to merge 1 commit into from

Conversation

geckofu
Copy link
Contributor

@geckofu geckofu commented Nov 5, 2019

Issue #, if available:
None

Description of changes:
'sh' executable is required by aws-sdk-go to invoke credential_process.
So I'm proposing to use alpine as the base image for Docker build, then we can mount any binary/data required to call the credential_process.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

'sh' excutable is required by aws-sdk-go credential_process
@allisaurus
Copy link
Contributor

Hi @geckofu - We only distribute images that are based on Amazon Linux ("amazonlinux" in DockerHub) or scratch. However, the use case you bring up re: creds is definitely valid, so I've made a feature request so we can track adding this capability to the image.

Thanks for taking the time to submit this!

@allisaurus allisaurus closed this Nov 5, 2019
@geckofu
Copy link
Contributor Author

geckofu commented Nov 6, 2019

@allisaurus thanks, I'll follow up there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants