Added a custom user agent for calls made to sts and iam #9
Conversation
| ) | ||
|
|
||
| // UserAgentHeader is the header for a User Agent | ||
| const UserAgentHeader = "User-Agent" |
There was a problem hiding this comment.
nit: looks like this can be private since noone else is using it.
|
@efekarakus I don't think there's a way to view the request details to check the header since its made over HTTPS. I'm not super sure about this though.
|
|
@PettitWesley I meant for example can we use the tool locally and see some metric increment in the backend? |
| // CustomUserAgentHandler returns a http request handler that sets a custom user agent to all aws requests | ||
| func CustomUserAgentHandler() request.NamedHandler { | ||
| return request.NamedHandler{ | ||
| Name: "ECSCLIUserAgentHandler", |
There was a problem hiding this comment.
C/P leftovers? We should rename this "ECSLocalEndpointsAgentHandler", yes?
PettitWesley
force-pushed
the
user-agent
branch
2 times, most recently
from
3681abb
to
2ad10f1
Compare
go.sum
Outdated
| @@ -1,6 +1,7 @@ | |||
| github.com/Microsoft/go-winio v0.4.12/go.mod h1:VhR8bwka0BXejwEJY73c50VrPtXAaKcyvVC4A4RozmA= | |||
| github.com/aws/amazon-ecs-agent v1.26.0 h1:kT/JZYXpCUXSjNaTWrYjlCPayWCV6dXaMQKOYq5JLfo= | |||
| github.com/aws/amazon-ecs-agent v1.26.0/go.mod h1:as/yyU3OZwCtKXO0Bv9dieYPupNo7jnNNZRNQTu9Row= | |||
| github.com/aws/amazon-ecs-cli v1.13.0 h1:cOOwtpChp2JhDK7PkIoHN5OKNhCPSQhaL7n3Pz7nIYk= | |||
There was a problem hiding this comment.
can this be removed? I don't see anywhere new that's using it
There was a problem hiding this comment.
huh.... this is autogenerated.. not sure why it didn't get auto-removed when I re-built after removing it from go.mod
Basically just copied from the following ECS CLI code:
https://github.com/aws/amazon-ecs-cli/blob/master/ecs-cli/modules/clients/aws/ecs/client.go#L77
https://github.com/aws/amazon-ecs-cli/blob/master/ecs-cli/modules/clients/user_agent.go
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.