cleanup al2023 templates #1682
Merged
cleanup al2023 templates #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndbaker1
force-pushed
the
templates
branch
2 times, most recently
from
8451c75
to
70de25f
Compare
|
/ci |
|
@ndbaker1 the workflow that you requested has completed. 🎉
|
|
/ci |
|
@ndbaker1 the workflow that you requested has completed. 🎉
|
|
@ndbaker1 the workflow that you requested has completed. 🎉
|
|
reran the 1.23 job due to some throttling, passes now 🎉 |
Issacwww
approved these changes
Feb 22, 2024
cartermckinnon
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
cleanup unused variables from prior refactoring and ensure no-op options do not appear in docs
also fix Makefile miss causing build issues in 1.23-1.24
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Testing Done
See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.