Add InstanceIdNodeName feature gate #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
Issacwww
changed the title
ndbaker1
reviewed
Mar 20, 2024
ndbaker1
reviewed
Mar 23, 2024
ndbaker1
reviewed
Mar 23, 2024
ndbaker1
reviewed
Mar 23, 2024
ndbaker1
reviewed
Mar 23, 2024
|
How about |
I think it was already close, like just referencing kubelet docs and seems like the pattern is usually |
|
+1 for |
ndbaker1
reviewed
Mar 25, 2024
cartermckinnon
changed the title
Issacwww
force-pushed
the
optInNodeName
branch
2 times, most recently
from
69e2f1e
to
62145d8
Compare
|
/ci |
|
@Issacwww the workflow that you requested has completed. 🎉
|
Issacwww
force-pushed
the
optInNodeName
branch
2 times, most recently
from
e22cb6d
to
4a62365
Compare
Issacwww
commented
Apr 11, 2024
cartermckinnon
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Opt-in Instance Id as Node name for Launch template case
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Testing Done
See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.