Added more logging in Scheduler w.r.t. StreamConfigs.
#1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelaezryan
reviewed
Mar 6, 2023
| retrievalConfig = new RetrievalConfig(kinesisClient, multiStreamTracker, applicationName) | ||
| .retrievalFactory(retrievalFactory); | ||
| leaseManagementConfig = new LeaseManagementConfig(tableName, dynamoDBClient, kinesisClient, | ||
| workerIdentifier).leaseManagementFactory(new TestKinesisLeaseManagementFactory(true, true)); | ||
| scheduler = new Scheduler(checkpointConfig, coordinatorConfig, leaseManagementConfig, lifecycleConfig, | ||
| metricsConfig, processorConfig, retrievalConfig); | ||
| scheduler.initialize(); | ||
| shardDetectorMap.values().stream() |
There was a problem hiding this comment.
For my own understanding. Why is .stream() omitted from a handful of the tests? I presume it's not (no longer ?) necessary but would like to understand why.
There was a problem hiding this comment.
FYI, this SO thread captures a significant amount of detail: https://stackoverflow.com/questions/23218874/what-is-difference-between-collection-stream-foreach-and-collection-foreach tl;dr They're (mostly) interchangeable.
Primary motivation here is to reduce IDE warnings (e.g., "stream().forEach()" can be replaced with "forEach()") to increase the visibility of other warnings.
pelaezryan
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Added more logging in
Schedulerw.r.t.StreamConfigs.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.