Adding resharding integration tests and changing ITs to not run by default #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… integration tests to not run by default
stair-aws
reviewed
Jun 27, 2023
Comment on lines
98
to
100
| Thread.sleep(TimeUnit.SECONDS.toMillis(60 * 3)); | ||
| } else { | ||
| Thread.sleep(TimeUnit.SECONDS.toMillis(60 * 8)); |
There was a problem hiding this comment.
KISS: use TimeUnit.MINUTES instead of converting seconds.
DRY: The only variable changing here is the duration.
final int sleepMinutes = (consumerConfig.getReshardConfig() == null) ? 3 : 8;
Thread.sleep(TimeUnit.MINUTES.toMillis(sleepMinutes));
What guarantees these magic numbers will be sufficient? How might the code be enhanced to avoid static waits?
Consider reading for ideas:
|
|
||
| // Reshard logic if required for the test | ||
| if (consumerConfig.getReshardConfig() != null) { | ||
| log.info("------------------------- Reshard Config found -----------------------------"); |
There was a problem hiding this comment.
Nit: --- is unnecessary.
This log statement lacks context. Log the reshard config.
| // Send dummy data to stream | ||
| this.producerExecutor = Executors.newSingleThreadScheduledExecutor(); | ||
| this.producerFuture = producerExecutor.scheduleAtFixedRate(this::publishRecord, 60, 1, TimeUnit.SECONDS); | ||
| producerExecutor = Executors.newSingleThreadScheduledExecutor(); |
There was a problem hiding this comment.
This instantiation should occur outside this block, otherwise there's a non-zero risk that an Exception, or future refactor, might raise NPEs.
amazon-kinesis-client/src/test/java/software/amazon/kinesis/application/TestConsumer.java
Outdated
Show resolved
Hide resolved
amazon-kinesis-client/src/test/java/software/amazon/kinesis/application/TestConsumer.java
Outdated
Show resolved
Hide resolved
amazon-kinesis-client/src/test/java/software/amazon/kinesis/application/TestConsumer.java
Outdated
Show resolved
Hide resolved
amazon-kinesis-client/src/test/java/software/amazon/kinesis/application/TestConsumer.java
Outdated
Show resolved
Hide resolved
amazon-kinesis-client/src/test/java/software/amazon/kinesis/application/TestConsumer.java
Outdated
Show resolved
Hide resolved
stair-aws
reviewed
Jun 28, 2023
| } else { | ||
| log.info("No scaling factor found in queue"); | ||
| } | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
Whenever possible, please be more explicit than Exception. Catching Exception|RuntimeException|Throwable is generally regarded as bad smell.
…n in succession becuase of incorrect closing of threads
ZeyuLi-AWS
requested changes
Aug 2, 2023
| @@ -152,6 +183,16 @@ private void startConsumer() { | |||
| this.consumerFuture = consumerExecutor.schedule(scheduler, 0, TimeUnit.SECONDS); | |||
| } | |||
|
|
|||
| public void stopProducer() { | |||
ZeyuLi-AWS
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adding KCL 2.x reshard integration test. Updating settings in pom.xml so that integration tests don't run by default. The instructions to build source and run tests in README has been updated to reflect this.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.