add test case for StreamIdentifier serialization #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stair-aws
approved these changes
Aug 22, 2023
| @@ -44,7 +44,8 @@ public void testMultiStreamDeserializationFail() { | |||
| "123456789012:stream-name:", // missing creation epoch | |||
| "123456789012:stream-name:-123", // negative creation epoch | |||
| "123456789012:stream-name:abc", // non-numeric creation epoch | |||
| "" | |||
| "", | |||
| "::" // missing account id, stream name, and epoch | |||
There was a problem hiding this comment.
FYI: you could have inserted this after line ~38 to avoid the unnecessary s/""/"",/ edit. Always appending to the tail:
- may unnecessarily increase the blast radius of the edit (unless there's a pragmatic reason like ordering)
- increases the chance of merge conflicts (e.g., two+ contributors append to tail; likely everyone but the first-to-merge suffers a conflict)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Add a test case to make sure the pattern "::" is recognized as an invalid StreamIdentifier
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.