Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide streamArn in getRecords request #1219

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

furq-aws
Copy link
Contributor

@furq-aws furq-aws commented Oct 26, 2023

Issue #, if available:
N/A.

Description of changes:
Include streamARN in getRecords requests when present.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@furq-aws furq-aws added the v2.x Issues related to the 2.x version label Oct 26, 2023
Copy link
Contributor

@lucienlu-aws lucienlu-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add unit tests but LGTM

@furq-aws furq-aws merged commit f90b1b1 into awslabs:master Oct 26, 2023
1 check passed
@furq-aws furq-aws deleted the caa-getrecordsrequest branch October 26, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.x Issues related to the 2.x version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants