Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Deletion protection config #1260

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Add Deletion protection config #1260

merged 3 commits into from
Feb 20, 2024

Conversation

lucienlu-aws
Copy link
Contributor

Issue #, if available:

Description of changes:
The KCL lease table does not have an option to be created with deletion protection enabled. This commit adds the option to be configured via the LeaseManagementConfig

Sample usage

leaseManagementConfig = configsBuilder.leaseManagementConfig()
                    .initialPositionInStream(InitialPositionInStreamExtended.newInitialPosition(config.getKclInitialPosition()))
                    .initialLeaseTableReadCapacity(50).initialLeaseTableWriteCapacity(50).deletionProtectionEnabled(true)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@lucienlu-aws lucienlu-aws changed the title Deletion protection config Add Deletion protection config Feb 20, 2024
brendan-p-lynch
brendan-p-lynch reviewed Feb 20, 2024
View reviewed changes
Copy link
Contributor

@brendan-p-lynch brendan-p-lynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in two comments on naming conventions, otherwise it looks good.

...nt/src/main/java/software/amazon/kinesis/leases/dynamodb/DynamoDBLeaseManagementFactory.java Outdated Show resolved Hide resolved
amazon-kinesis-client/src/main/java/software/amazon/kinesis/leases/LeaseManagementConfig.java Outdated Show resolved Hide resolved
@lucienlu-aws lucienlu-aws merged commit b2eb38e into awslabs:master Feb 20, 2024
1 check passed
@lucienlu-aws lucienlu-aws deleted the deletion-protection-config branch February 20, 2024 22:47
akidambisrinivasan pushed a commit to akidambisrinivasan/amazon-kinesis-client that referenced this pull request Apr 29, 2024
@lucienlu-aws @akidambisrinivasan
Add Deletion protection config (awslabs#1260)
2d36789 
* Add deletionProtectionEnabled config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akidambisrinivasan akidambisrinivasan akidambisrinivasan approved these changes

@brendan-p-lynch brendan-p-lynch brendan-p-lynch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lucienlu-aws @akidambisrinivasan @brendan-p-lynch