Update RetrievalFactory implementations to utilize the StreamIdentifier field of StreamConfig #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er field of StreamConfig
furq-aws
force-pushed
the
streamidentifier-propagation
branch
from
5a26958
to
568eae3
Compare
| * @param streamConfig The {@link StreamConfig} containing details for the stream. | ||
| * @param metricsFactory The {@link MetricsFactory} for recording metrics. | ||
| * @return A {@link RecordsPublisher} instance for retrieving records from the shard. | ||
| */ | ||
| default RecordsPublisher createGetRecordsCache(ShardInfo shardInfo, StreamConfig streamConfig, MetricsFactory metricsFactory) { |
There was a problem hiding this comment.
ShardInfo already has streamConfig, can we not make sure shardInfo has the correct streamConfig instead of passing it in
There was a problem hiding this comment.
Per discussion with @akidambisrinivasan and @lucienlu-aws -
Submitted a PR to embed a reference to StreamConfig within ShardInfo.
However, due to the increased risk of backwards-incompatibility within that approach, we have decided to proceed with this current approach for faster delivery.
lucienlu-aws
approved these changes
Apr 11, 2024
| final StreamConfig streamConfig, | ||
| final MetricsFactory metricsFactory) { | ||
| @NonNull final StreamConfig streamConfig, | ||
| @Nullable final MetricsFactory metricsFactory) { |
There was a problem hiding this comment.
This is not even used?
There was a problem hiding this comment.
Correct, the MetricsFactory argument doesn't seem to actually be used in the FanOutRetrievalFactory implementation.
akidambisrinivasan
approved these changes
Apr 15, 2024
vincentvilo-aws
pushed a commit
to vincentvilo-aws/amazon-kinesis-client
that referenced
this pull request
Apr 17, 2024
…er field of StreamConfig (awslabs#1291)
akidambisrinivasan
pushed a commit
to akidambisrinivasan/amazon-kinesis-client
that referenced
this pull request
Apr 29, 2024
…er field of StreamConfig (awslabs#1291)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A.
Description of changes:
Update the
RetrievalFactoryimplementations to utilize the pre-existingStreamIdentifierfrom theStreamConfigargument.A
StreamIdentifierprovided fromScheduler(throughStreamConfig) may contain additional information such as the stream's ARN, and we don't need to reconstruct it fromShardInfosince it is already available here.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.