Add missing init for DynamoDB client in Worker (#51) #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the dynamoDBEndpoint configuration property was added, not all paths that should have made use of it were updated. Both paths now use the config value to set up the DynamoDB client.
|
Thanks for doing this. If you could please confirm that we can use, modify, copy, and redistribute this contribution. Thanks. |
|
Yes, of course! You may use, modify, copy, and redistribute this contribution. |
pfifer
added a commit
to pfifer/amazon-kinesis-client
that referenced
this pull request
Feb 27, 2017
* Fixed an issue building JavaDoc for Java 8. * [Issue awslabs#18](awslabs#18) * [PR awslabs#141](awslabs#141) * Reduce Throttling Messages to WARN, unless throttling occurs 6 times consecutively. * [Issue awslabs#4](awslabs#4) * [PR awslabs#140](awslabs#140) * Fixed two bugs occurring in requestShutdown. * Fixed a bug that prevented the worker from shutting down, via requestShutdown, when no leases were held. * [Issue awslabs#128](awslabs#128) * Fixed a bug that could trigger a NullPointerException if leases changed during requestShutdown. * [Issue awslabs#129](awslabs#129) * [PR awslabs#139](awslabs#139) * Upgraded the AWS SDK Version to 1.11.91 * [PR awslabs#138](awslabs#138) * Use an executor returned from `ExecutorService.newFixedThreadPool` instead of constructing it by hand. * [PR awslabs#135](awslabs#135) * Correctly initialize DynamoDB client, when endpoint is explicitly set. * [PR awslabs#142](awslabs#142)
pfifer
added a commit
that referenced
this pull request
Feb 27, 2017
* Fixed an issue building JavaDoc for Java 8. * [Issue #18](#18) * [PR #141](#141) * Reduce Throttling Messages to WARN, unless throttling occurs 6 times consecutively. * [Issue #4](#4) * [PR #140](#140) * Fixed two bugs occurring in requestShutdown. * Fixed a bug that prevented the worker from shutting down, via requestShutdown, when no leases were held. * [Issue #128](#128) * Fixed a bug that could trigger a NullPointerException if leases changed during requestShutdown. * [Issue #129](#129) * [PR #139](#139) * Upgraded the AWS SDK Version to 1.11.91 * [PR #138](#138) * Use an executor returned from `ExecutorService.newFixedThreadPool` instead of constructing it by hand. * [PR #135](#135) * Correctly initialize DynamoDB client, when endpoint is explicitly set. * [PR #142](#142)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
dynamoDBEndpointconfiguration property was added, not all paths thatshould have made use of it were updated. Both paths now use the config value to
set up the DynamoDB client.