Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Documentation for a Variety of Components #170

Merged
merged 4 commits into from
Jun 1, 2017

Conversation

pfifer
Copy link
Contributor

@pfifer pfifer commented May 19, 2017

Updated the documentation for Idle Time Between Reads, and Shutdown to indicate the special requirements of both methods.

Additionally the KPL will now build the javadoc, and source jars during the jar goal.

Updated the documentation to indicates that it is only used when
GetRecords returns an empty set of records.
When the KCL calls shutdown with the reason TERMINATE the customer's
application must checkpoint, or the KCL will not make progress.
@pfifer
Copy link
Contributor Author

pfifer commented May 24, 2017

This fixes #169

@pfifer pfifer merged commit e121691 into awslabs:master Jun 1, 2017
@pfifer pfifer deleted the idleTime-doc branch June 1, 2017 15:26
@pfifer pfifer added this to the v1.8.0 milestone Jun 6, 2017
@pfifer pfifer modified the milestones: v1.7.6, v1.8.0 Jun 21, 2017
pfifer added a commit to pfifer/amazon-kinesis-client that referenced this pull request Jun 21, 2017
* Added support for graceful shutdown in MultiLang Clients
  * PR awslabs#174
  * PR awslabs#182
* Updated documentation for `v2.IRecordProcessor#shutdown`, and `KinesisClientLibConfiguration#idleTimeBetweenReadsMillis`
  * PR awslabs#170
* Updated to version 1.11.151 of the AWS Java SDK
  * PR awslabs#183
pfifer added a commit that referenced this pull request Jun 22, 2017
* Added support for graceful shutdown in MultiLang Clients
  * PR #174
  * PR #182
* Updated documentation for `v2.IRecordProcessor#shutdown`, and `KinesisClientLibConfiguration#idleTimeBetweenReadsMillis`
  * PR #170
* Updated to version 1.11.151 of the AWS Java SDK
  * PR #183
@sammefford sammefford mentioned this pull request Jan 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant