Fix for the lease losses in the PrefetchCache and AsyncGetRecordsStrategy caused due to ExpiredIteratorException #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tegy caused due to ExpiredIteratorException.
pfifer
approved these changes
Nov 8, 2017
| @@ -162,6 +171,14 @@ public void run() { | |||
| prefetchCounters.added(processRecordsInput); | |||
| } catch (InterruptedException e) { | |||
| log.info("Thread was interrupted, indicating shutdown was called on the cache."); | |||
| } catch (ExpiredIteratorException e) { | |||
| log.info(String.format("ShardId %s: getRecords threw ExpiredIteratorException - restarting" | |||
| + " after greatest seqNum passed to customer", shardId), e); | |||
There was a problem hiding this comment.
This isn't actually true, it restarting from the last accepted sequence number. That may be in the queue waiting to be processed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit includes