Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up configuration #385

Merged
merged 1 commit into from
Aug 27, 2018
Merged

Conversation

sahilpalvia
Copy link
Contributor

Issue #, if available:
N/A

Description of changes:

  • Deprecating createGracefulShutdownCoordinator from CoordinatorFactory
  • Deprecating createWorkerStateChangeListener from CoordinatorFactory
  • Introduing gracefulShutdownCoordinator and workerStateChangeListener configurations to CoordinatorConfig
  • Switching to use CoordinatorFactory only if the new configurations in code are set to null

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

* Deprecating createGracefulShutdownCoordinator from CoordinatorFactory
* Deprecating createWorkerStateChangeListener from CoordinatorFactory
* Introduing gracefulShutdownCoordinator and workerStateChangeListener configurations to CoordinatorConfig
* Switching to use CoordinatorFactory only if the new configurations in code are set to null
@sahilpalvia sahilpalvia added the v2.x Issues related to the 2.x version label Aug 27, 2018
@pfifer pfifer added this to the v2.0.2 milestone Aug 27, 2018
@pfifer pfifer merged commit 7734561 into awslabs:master Aug 27, 2018
@sahilpalvia sahilpalvia deleted the coordinator-config-fix branch August 27, 2018 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.x Issues related to the 2.x version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants