Added an API on LeaseCoordinator and LeaseTaker to get all leases for… #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sahilpalvia
suggested changes
Oct 2, 2018
| /** | ||
| * @return All leases | ||
| */ | ||
| Collection<Lease> getAllAssignments(); |
There was a problem hiding this comment.
Could you rename the method to allLeases in both the interfaces and return a list. Could you also implement a default method to the newly added methods, since they are added to publicly exposed interfaces.
default List<Lease> allLeases() {
return Collection.emptyList();
}Could you also add javadoc for the methods
| */ | ||
| @Override | ||
| public synchronized Collection<Lease> getAllLeases() { | ||
| return Collections.unmodifiableCollection(new ArrayList<Lease>(allLeases.values())); |
There was a problem hiding this comment.
Just a suggestion, minimum requirement for the KCL is Java 8+. So you could get away with new ArrayList<>(allLeases.values())
| coordinator.runLeaseTaker(); | ||
|
|
||
| Collection<Lease> allAssignments = coordinator.getAllAssignments(); | ||
| assertEquals(allAssignments.size(), addedLeases.size()); |
There was a problem hiding this comment.
assertThat(..., equalTo())
| taker.takeLeases(); | ||
|
|
||
| Collection<Lease> allLeases = taker.getAllLeases(); | ||
| assertEquals(allLeases.size(), addedLeases.size()); |
There was a problem hiding this comment.
assertThat(..., equalTo)
sahilpalvia
approved these changes
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… the application
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.