Fix #36 Avoid failure on start due to CreateTable #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current implementation uses a ResourceInUse side-effect to detect that the table already exists. This requires that the user/role running the KCL have the CreateTable permission. Update the LeaseManager to check if the table exists to allow limited privilege users to run KCL code.
|
I have a change similar this prepared that I should have ready for deployment soon. |
pfifer
added a commit
that referenced
this pull request
Jul 21, 2016
Attempt to see if the lease table exists before attempting to create it. Related/Fixes PR#67 - #67
Closed
|
The change is committed, and will be released to Maven soon. |
ychunxue
added a commit
to ychunxue/amazon-kinesis-client
that referenced
this pull request
Jul 9, 2020
KCL 1.x ShardEnd Shard Sync and Lease table ChildShard persistence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation uses a ResourceInUse side-effect to detect that the table already exists.
This requires that the user/role running the KCL have the CreateTable permission. Update the
LeaseManager to check if the table exists to allow limited privilege users to run KCL code.