Make use of Java 8 to simplify computeLeaseCounts()
#847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible to remove quite a few lines of code from the method using Java 8 features (a `groupingBy` Collector, etc). Java 8 is the minimum supported version of the KCL since awslabs#176 was merged in July 2017. See also: https://docs.oracle.com/javase/8/docs/api/java/util/stream/package-summary.html#package.description http://cr.openjdk.java.net/~briangoetz/lambda/lambda-translation.html
rtyley
changed the title
computeLeaseCounts()
joshua-kim
approved these changes
Oct 4, 2021
|
Many thanks @joshua-kim! I also have a couple of other open PRs, if you have time to review them: |
|
I reviewed the smaller of the two; #848 which aims to optimize lease convergence time sounds promising but is a change to a rather critical part of KCL. Don't have an ETA of when I'll be able to look into/test it currently. |
|
Sure- thanks for taking a quick look anyway, and of course for merging the logging fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to remove quite a few lines of code from the method using Java 8 features (
groupingByCollector, etc).Java 8 is the minimum supported version of the KCL since PR #176 was merged in July 2017.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.