Emit Glue Schema Registry usage metrics #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacktooth
force-pushed
the
master
branch
2 times, most recently
from
cc31f8c
to
156bbdc
Compare
joshua-kim
reviewed
Sep 29, 2021
| @@ -0,0 +1,5 @@ | |||
| package software.amazon.kinesis.common; | |||
|
|
|||
| public final class KinesisConsumerLibraryPackage { | |||
There was a problem hiding this comment.
nit: Can we call this KinesisClientLibraryPackage instead?
joshua-kim
reviewed
Sep 29, 2021
| @@ -324,6 +324,45 @@ | |||
| </execution> | |||
| </executions> | |||
| </plugin> | |||
|
|
|||
| <!-- Required for generating maven version as a Java class for runtime access --> | |||
shanmsac
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Sets the User Agent for the de-serializer to "kcl". This enables the underlying Glue Schema Registry library to emit UserAgent metrics.
Testing
Build successful.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.