Revert commit for e638c17 and added new test #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change caused a regression for leases without owners. Added unit test.
shanmsac
changed the title
| when(metricsFactory.createMetrics()).thenReturn(new NullMetricsScope()); | ||
| when(timeProvider.call()).thenReturn(1000L); | ||
|
|
||
| Map<String, Lease> actualOutput = dynamoDBLeaseTaker.takeLeases(timeProvider); |
There was a problem hiding this comment.
is it possible to test against expiredLeases? can we change computeLeasesToTake to visible to test?
There was a problem hiding this comment.
Added additional test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Reverting the use of Java 8 for computing lease count. Lease can be without owners and groupingBy does not accept null key.
Added new unit test.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.