Pass proxy configuration in the Java wrapper to c++ library #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yatins47
reviewed
Apr 14, 2021
...ucer/src/main/java/com/amazonaws/services/kinesis/producer/KinesisProducerConfiguration.java
Show resolved
Hide resolved
...ucer/src/main/java/com/amazonaws/services/kinesis/producer/KinesisProducerConfiguration.java
Outdated
Show resolved
Hide resolved
xinguaws
force-pushed
the
feature/proxy_support_0.14.6
branch
from
e83a27b
to
9d7f8ea
Compare
Added generated code
xinguaws
force-pushed
the
feature/proxy_support_0.14.6
branch
from
9d7f8ea
to
b62dbaa
Compare
|
any update on this PR ? |
|
Fixed the build in #356, re-running travis before merging. |
|
Reopened to re-enqueue a build... |
|
The Xenial build is passing, looks like Travis is having other issues unrelated to this and can't clone the repo for some reason. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue numbers: #13 #186
Description of changes: Pass proxy configuration from java wrapper to C++ AWS SDK.
This change has been built and tested in a customer environment, no issues are found.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.