Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing build issues due to stale CA certs #388

Merged
merged 2 commits into from
Dec 30, 2021
Merged

Fixing build issues due to stale CA certs #388

merged 2 commits into from
Dec 30, 2021

Conversation

joshua-kim
Copy link
Contributor

@joshua-kim joshua-kim commented Nov 3, 2021

Issue #, if available:

Description of changes:

CI has been failing since curl breaks if the system's CA cert is stale. Adding a step in the build scripts to pull the latest CA cert and use that for the curl requests that the build script uses.

Before:

curl: (60) The certificate issuer's certificate has expired.  Check your system date and time.
More details here: http://curl.haxx.se/docs/sslcerts.html

Currently this passes, tested this by running the build script on a AL2012 host and verifying the bootstrap script is able to pull dependencies via curl.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@zengyu714 zengyu714 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zengyu714 zengyu714 self-requested a review December 30, 2021 18:54
@zengyu714 zengyu714 merged commit 488df2f into master Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants