Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StreamARN parameter to support CAA #552

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Add StreamARN parameter to support CAA #552

merged 1 commit into from
Dec 14, 2023

Conversation

aakkem
Copy link
Contributor

@aakkem aakkem commented Dec 14, 2023

Issue #, if available:
N/A

Description of changes:
In order for users to benefit from CAA - cross account access, StreamARN parameter is included into the requests.

Testing:

Compiled and tested with amazon-kinesis-producer-sample

[kpl-daemon-0003] INFO com.amazonaws.services.kinesis.producer.LogInputStreamReader - [2023-12-13 17:59:01.756904] [0x00002bd9][0x00007fa212063700] [info] [kinesis_producer.cc:226] Created pipeline for stream "kpltest"
[kpl-daemon-0003] INFO com.amazonaws.services.kinesis.producer.LogInputStreamReader - [2023-12-13 17:59:01.774553] [0x00002bd9][0x00007fa212063700] [info] [pipeline.h:226] StreamARN "arn:aws:kinesis:us-west-2:056772968073:stream/kpltest" has been successfully configured, and will be used in requests including ListShards and PutRecords
[kpl-daemon-0003] INFO com.amazonaws.services.kinesis.producer.LogInputStreamReader - [2023-12-13 17:59:01.774630] [0x00002bd9][0x00007fa212063700] [info] [shard_map.cc:89] Updating shard map for stream "kpltest"
[kpl-daemon-0003] INFO com.amazonaws.services.kinesis.producer.LogInputStreamReader - [2023-12-13 17:59:01.806115] [0x00002bd9][0x00007fa1fabfd700] [info] [shard_map.cc:151] Successfully updated shard map for stream "kpltest" (arn: "arn:aws:kinesis:us-west-2:056772968073:stream/kpltest"). Found 4 shards

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aakkem aakkem requested a review from shanmsac December 14, 2023 19:31
Copy link
Contributor

@shanmsac shanmsac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aakkem aakkem merged commit c26c293 into master Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants