Release build (#237)

* Switch to ASSERT_EQ from assert to prevent release build optimization

* Fix assert

* Cleanup log statements

CMakeLists.txt

@@ -31,6 +31,11 @@ add_definitions(-DSDK_VERSION=\"${GIT_COMMIT_HASH}\")
 add_definitions(-DDETECTED_GIT_HASH)
 
 
+if(NOT CMAKE_BUILD_TYPE)
+  message(STATUS "Setting CMAKE_BUILD_TYPE to Release by default")
+  set(CMAKE_BUILD_TYPE "Release" CACHE STRING "Choose the type of build." FORCE)
+endif()
+
 if(BUILD_SHARED_LIBS)
   set(LIBTYPE SHARED)
 elseif()

src/client/src/InputValidator.c

@@ -372,7 +372,7 @@ VOID fixupClientInfo(PClientInfo pClientInfo, PClientInfo pOrigClientInfo)
         pClientInfo->offlineBufferAvailabilityTimeout = MAX_BLOCKING_PUT_WAIT;
     }
 
-    if (pClientInfo->loggerLogLevel == 0 || pClientInfo->loggerLogLevel > LOG_LEVEL_SILENT) {
+    if (pClientInfo->loggerLogLevel == 0 || pClientInfo->loggerLogLevel > LOG_LEVEL_PROFILE) {
         pClientInfo->loggerLogLevel = LOG_LEVEL_WARN;
     }
 

tst/client/ClientTestFixture.h

@@ -373,9 +373,11 @@ class ClientTestBase : public ::testing::Test {
     void initTestMembers()
     {
         UINT32 logLevel = 0;
+        STATUS retStatus = STATUS_SUCCESS;
         auto logLevelStr = GETENV("AWS_KVS_LOG_LEVEL");
         if (logLevelStr != NULL) {
-            assert(STRTOUI32(logLevelStr, NULL, 10, &logLevel) == STATUS_SUCCESS);
+            retStatus = STRTOUI32(logLevelStr, NULL, 10, &logLevel);
+            ASSERT_EQ(retStatus, STATUS_SUCCESS);
         }
 
         // Zero things out
@@ -924,9 +926,11 @@ class ClientTestBase : public ::testing::Test {
     virtual void SetUpWithoutClientCreation()
     {
         UINT32 logLevel = 0;
+        STATUS retStatus = STATUS_SUCCESS;
         auto logLevelStr = GETENV("AWS_KVS_LOG_LEVEL");
         if (logLevelStr != NULL) {
-            assert(STRTOUI32(logLevelStr, NULL, 10, &logLevel) == STATUS_SUCCESS);
+            retStatus = STRTOUI32(logLevelStr, NULL, 10, &logLevel);
+            ASSERT_EQ(retStatus, STATUS_SUCCESS);
             SET_LOGGER_LOG_LEVEL(logLevel);
         }