-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API for specifying thread stack size #243
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #243 +/- ##
===========================================
- Coverage 80.34% 80.30% -0.05%
===========================================
Files 53 53
Lines 10808 10826 +18
===========================================
+ Hits 8684 8694 +10
- Misses 2124 2132 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Windows CI tests weren't running at all the WebRTC C SDK PR due to an unrelated issue (couldn't find ZLIB so the build didn't finish) so we weren't able to see if this works there. I pushed a commit to that branch and ran the CI and it's all good on Windows except for some file caching tests which have been resolved in another PR, so I'm now approving this PR.
Issue #, if available:
What was changed?
Added API to support specifying stack size of threads at time of creation.
Added an ability to specify default stack sizes at compile time.
Why was it changed?
Libraries that use this asset as a dependency needed to be able to customize their thread stack sizes
How was it changed?
New API added, check for default compile time variable.
What testing was done for the changes?
Old tests passing, new tests added. Additional changes made in upstream libraries using this change that also have tests passing.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.