Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API for specifying thread stack size #243

Merged
merged 21 commits into from
Feb 28, 2024
Merged

Conversation

jdelapla
Copy link
Contributor

@jdelapla jdelapla commented Feb 7, 2024

Issue #, if available:

What was changed?
Added API to support specifying stack size of threads at time of creation.
Added an ability to specify default stack sizes at compile time.

Why was it changed?
Libraries that use this asset as a dependency needed to be able to customize their thread stack sizes

How was it changed?
New API added, check for default compile time variable.

What testing was done for the changes?
Old tests passing, new tests added. Additional changes made in upstream libraries using this change that also have tests passing.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 80.30%. Comparing base (2b835f3) to head (8c447bd).
Report is 9 commits behind head on develop.

❗ Current head 8c447bd differs from pull request most recent head cb8154c. Consider uploading reports for the commit cb8154c to get more accurate results

Files Patch % Lines
src/utils/src/FileIo.c 40.00% 3 Missing ⚠️
src/utils/src/Thread.c 83.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #243      +/-   ##
===========================================
- Coverage    80.34%   80.30%   -0.05%     
===========================================
  Files           53       53              
  Lines        10808    10826      +18     
===========================================
+ Hits          8684     8694      +10     
- Misses        2124     2132       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/utils/src/Thread.c Outdated Show resolved Hide resolved
src/utils/src/Thread.c Outdated Show resolved Hide resolved
src/utils/src/Thread.c Outdated Show resolved Hide resolved
src/utils/src/Thread.c Outdated Show resolved Hide resolved
src/utils/src/Thread.c Show resolved Hide resolved
src/utils/src/Thread.c Outdated Show resolved Hide resolved
src/utils/src/Thread.c Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
tst/utils/Thread.cpp Outdated Show resolved Hide resolved
tst/utils/Thread.cpp Show resolved Hide resolved
tst/utils/Thread.cpp Show resolved Hide resolved
src/utils/src/Thread.c Outdated Show resolved Hide resolved
disa6302
disa6302 previously approved these changes Feb 26, 2024
src/utils/src/Thread.c Outdated Show resolved Hide resolved
Copy link
Contributor

@hassanctech hassanctech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Windows CI tests weren't running at all the WebRTC C SDK PR due to an unrelated issue (couldn't find ZLIB so the build didn't finish) so we weren't able to see if this works there. I pushed a commit to that branch and ran the CI and it's all good on Windows except for some file caching tests which have been resolved in another PR, so I'm now approving this PR.

@jdelapla jdelapla merged commit bb74264 into develop Feb 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants