Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change fragment metadata count from 25 to 10 #251

Merged
merged 5 commits into from
Mar 20, 2024

Conversation

niyatim23
Copy link
Contributor

@niyatim23 niyatim23 commented Mar 1, 2024

Issue #, if available:

What was changed?

  • Modified MAX_FRAGMENT_METADATA_COUNT to 10
  • Modified actions/checkout@v2 to v4
  • Moved from macos-11 to macos-12 as the former has been deprecated

Why was it changed?

  • Changed because that is the limit from the backend
  • v2 is an older version and v4 is the latest

How was it changed?

  • Updated the MAX_FRAGMENT_METADATA_COUNT
  • Updated the ci.yml

What testing was done for the changes?

  • The CI tests cover this change

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@niyatim23 niyatim23 marked this pull request as ready for review March 4, 2024 22:12
stefankiesz
stefankiesz previously approved these changes Mar 4, 2024
tst/client/StreamPutGetTest.cpp Show resolved Hide resolved
sirknightj
sirknightj previously approved these changes Mar 5, 2024
@sirknightj
Copy link
Contributor

@niyatim23 niyatim23 dismissed stale reviews from sirknightj and stefankiesz via f24ea54 March 5, 2024 22:32
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.36%. Comparing base (bb74264) to head (f883163).

❗ Current head f883163 differs from pull request most recent head f24ea54. Consider uploading reports for the commit f24ea54 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #251   +/-   ##
========================================
  Coverage    80.36%   80.36%           
========================================
  Files           53       53           
  Lines        10826    10826           
========================================
  Hits          8700     8700           
  Misses        2126     2126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hassanctech hassanctech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@niyatim23 niyatim23 merged commit 03c78cd into develop Mar 20, 2024
14 checks passed
@niyatim23 niyatim23 deleted the fix-metadata-tag-count branch March 20, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants