Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log line fix #253

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Log line fix #253

merged 1 commit into from
Apr 24, 2024

Conversation

disa6302
Copy link
Contributor

Issue #, if available:

What was changed?

  • Include stream name in the log line while stopping stream instead of handle.

Why was it changed?

  • Stream handle value is not informative. Stream name is

How was it changed?

  • stopKinesisVideoStreamSync(): [test] Synchronously stopping Kinesis Video Stream -> this is how it looks now.
  • Earlier: Synchronously stopping Kinesis Video Stream 123345353

What testing was done for the changes?

  • Tested with samples to confirm the change works.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@disa6302 disa6302 marked this pull request as ready for review April 24, 2024 17:40
@disa6302 disa6302 merged commit 1f1d947 into develop Apr 24, 2024
14 checks passed
@sirknightj sirknightj deleted the log-line branch April 24, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niyatim23 niyatim23 niyatim23 approved these changes

@stefankiesz stefankiesz stefankiesz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@disa6302 @niyatim23 @stefankiesz