Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split EFS from EKS Module #46

Closed
a13zen opened this issue Oct 5, 2022 · 4 comments
Closed

Split EFS from EKS Module #46

a13zen opened this issue Oct 5, 2022 · 4 comments
Assignees

Comments

@a13zen
Copy link
Contributor

a13zen commented Oct 5, 2022

I just reviewed this module...you are correct that the EFS is indeed created. I would suggest leaving the CNI addon support and just moving the EFS creation to a different module altogether...and parameterize the rest (storage class, etc)

@JunjieTang-D1
Copy link
Contributor

This is a good idea to split EFS from EKS module: we will have S3 connector and EFS as option for different workload

@qvacua
Copy link
Contributor

qvacua commented Nov 14, 2022

[x] Changing policy of EFS from DESTROY to RETAIN in core-eks is good to merge
[x] Leave EFS creation in core-eks to support backward compatability
[x] Create new storage module for efs
[x] Create ONE integration module for filesystem support (item #3) for EKS (integration to other services requires a new module)
[x] Multi-version support for core-eks module should be implemented with a 'mapping' of recommend drivers / controllers based on the eks version - and done on an as-needed basis

@dgraeber
Copy link
Contributor

After inspection, the EFS module is fairly simplistic, while the FSx module has many permutations. I would like to give some options about the use case for both in order to determine HOW they should be organized to

  1. create the resources
  2. integrate with EKS

@dgraeber
Copy link
Contributor

Module to create EFS and to integrate EFS to EKS completed on PR #78

FSx on Lustre support should be in a separate item / issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants