Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the page loads at end of process it is empty #34

Closed
bassmanitram opened this issue Mar 6, 2017 · 8 comments
Closed

When the page loads at end of process it is empty #34

bassmanitram opened this issue Mar 6, 2017 · 8 comments
Assignees

Comments

@bassmanitram
Copy link

bassmanitram commented Mar 6, 2017

Process [from fresh clone with no changes] completes successfully and opens a tab in Chrome (or FF) - which is empty.

Console log from chrome attached

@scotty-p
Copy link

scotty-p commented Mar 6, 2017

I can recreate this issue using ap-southeast-2 region

@brettstack
Copy link
Contributor

I'll spin up a fresh instance and see if I can repro (and fix). This is the error that's causing the problem:

Link.js:72Uncaught TypeError: Cannot read property 'createHref' of undefined

@brettstack brettstack self-assigned this Mar 6, 2017
@brettstack
Copy link
Contributor

Update ./dev-portal/package.json and change "react-router-dom": "^4.0.0-beta.4" to "react-router-dom": "4.0.0-beta.7".

From ./dev-portal run:

rm -rf node_modules
npm install
npm run start

After the final command kicks in, visit http://localhost:3000/ and verify it runs locally. Then, run npm run upload-site to deploy.

@brettstack
Copy link
Contributor

Root cause: react-router-dom is in beta; API is in flux. Since we allow minor version changes (^), the API changes in newer versions of react-router-dom beta broke the app.

Solution: Remove ^ from react-router dom. In fact, to be safe, we will be removing it from all packages.

@bassmanitram
Copy link
Author

Excellent - thanks - now onto a real API :)

@jose-rafael-marcano
Copy link

It didn't work for me

I had to add "react-router": "4.0.0-beta.7" in addition to current dependencies, but now I am not getting the sign in or register option. It is displaying Case Studies, APIs and Getting Started, but not register/login options. I am wondering if this is related to cache. Please @brettstack help out.

image

@jose-rafael-marcano
Copy link

I found the issue, it was a problem with my package.json. I had to add "react-router": "4.0.0-beta.7", in addition to "react-router-dom": "4.0.0-beta.7".
Thanks

@jessetarot
Copy link

@jose-rafael-marcano your solution of adding "react-router": "4.0.0-beta.7" to package.json
worked for me too. Thanks for posting.

brettstack added a commit that referenced this issue Jun 5, 2017
fix UI bug (react-router update); fix jquery.ba-bbq error; remove cognito custom resource (now native support); PureComponent; fixes #45 #34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants