Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ecs credentials provider fixes #132

Merged
merged 3 commits into from
May 7, 2021
Merged

Ecs credentials provider fixes #132

merged 3 commits into from
May 7, 2021

Conversation

bretambrose
Copy link
Contributor

@bretambrose bretambrose commented May 7, 2021 •
edited
Loading

  • Fix ecs credentials provider by massaging request construction:
    • Add Host and Accept-Encoding headers
    • Modify Accept header although it's probably not an issue
    • Always add Authorization header if the environment variable is set (matches other implementations)
    • Don't add keep alive header
    • Fix memory leak in ecs code path due to not cleaning up uri object

#119

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bretambrose bretambrose changed the title WIP Ecs credentials provider fixes May 7, 2021
@bretambrose bretambrose merged commit c74534c into main May 7, 2021
@bretambrose bretambrose deleted the EcsExperiment branch May 7, 2021 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinboswell justinboswell justinboswell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bretambrose @justinboswell