Use JSON module instead of cJSON #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies the code to use the JSON module in AWS C Common instead of directly using cJSON. This prevents duplicate copies/includes of cJSON, as well as helping reduce additional dependencies and code duplication.
…ommon.c does not initialize it in these tests
bretambrose
reviewed
Apr 15, 2022
bretambrose
approved these changes
Apr 15, 2022
|
Thanks for the reviews! Merging into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Modifies the code to use the JSON module in AWS C Common instead of directly using cJSON. This prevents duplicate copies/includes of cJSON, as well as helping reduce additional dependencies and code duplication.
Note - is dependent on the following PR: awslabs/aws-c-common#889
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.