Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ECS Credentials Provider to add support for AWS_CONTAINER_AUTHORIZATION_TOKEN_FILE #233

Merged
merged 18 commits into from
Apr 18, 2024

Conversation

waahm7
Copy link
Contributor

@waahm7 waahm7 commented Apr 17, 2024

Issue #, if available:

Description of changes:
Adds support for AWS_CONTAINER_AUTHORIZATION_TOKEN_FILE with the following priority

  1. auth_token parameter
  2. AWS_CONTAINER_AUTHORIZATION_TOKEN_FILE (env var which contains absolute path to the token file. The file will be re-read for each call to get credentials.)
  3. AWS_CONTAINER_AUTHORIZATION_TOKEN (env var which contains static auth token)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 78.26087% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 79.54%. Comparing base (0de6b27) to head (ea1dd45).

Files Patch % Lines
source/credentials_provider_ecs.c 77.27% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
- Coverage   79.55%   79.54%   -0.01%     
==========================================
  Files          33       33              
  Lines        5860     5872      +12     
==========================================
+ Hits         4662     4671       +9     
- Misses       1198     1201       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waahm7 waahm7 marked this pull request as ready for review April 17, 2024 23:00
@waahm7 waahm7 merged commit 277c8fb into main Apr 18, 2024
29 checks passed
@waahm7 waahm7 deleted the fix-ecs-creds-provider branch April 18, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants